TimeSpan Template Bug

[DieSlower]

Hello,

There seems to be a bug in the template code when it comes to timespans and the TimeSpan variable.

I have the following code in my properties:

[NinjaScriptProperty]
[Display(Name="Test Time", Description="Start of the daily trade time", Order=4, GroupName="Debuging")]
public TimeSpan mTestTime
{ get; set; } 

and set the value in

protected override void OnStateChange()
{
    if (State == State.SetDefaults)
    {
         mTestTime = new TimeSpan(2, 14, 18);
    }
} 

Everything runs fine, but when I save a template of my strategy, and load it later, the template does not save the values of the TimeSpan. All values become 00:00:00
Could this please be looked at?

V/R,
--Maxim S

[NinjaTrader_Emily]

Hello Maxim,

Thank you for your post.

TimeSpan objects can not be serialized, so I suspect that when you are saving your template the TimeSpan value is not properly saved and this is why you see 00:00:00 when you load the template again. There is a way to prevent this, however. You could convert the TimeSpan into a simple type, such as a string, so that the proper information may be serialized. We have an example "Using a simple type as the NinjaScriptProperty against types which cannot be serialized" on our help guide page here:

https://ninjatrader.com/support/helpGuides/nt8/ninjascriptpropertyattribute.htm

Another type of object that does not serialize well and needs to be converted to a string is a Brush. For another example of how to convert a non-serializable object into a simple type of object for serialization, please see the User Definable Color Inputs page here:

https://ninjatrader.com/support/helpGuides/nt8/user_definable_color_inputs.htm

The Microsoft C# documentation about Serialization may be found at the following publicly available page:

https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/concepts/serialization/

Please let us know if we may be of further assistance.

[DieSlower]

NinjaTrader_Emily You are right, the TimeSpan does not inherit System.Runtime.Serialization.ISerializable as DateTime does.
Is there another way to expose the timespan of a time value of some sort that can be serialized? I am not married to using TimeSpan, but making it a string will prevent NT8 from doing optimization on it.

[NinjaTrader_Emily]

Hello DieSlower,

Thank you for your response.

The platform would still be able to run an optimization on your strategy with the TimeSpan, however, the TimeSpan would not be incremented. If you would like to optimize the period of time, you could use int input values and ToTime(Time[0]) to check if the bar is within the hour and minutes selected. There has been other discussion on this topic in our forums, including the following post which includes a sample reference file:

https://ninjatrader.com/support/forum/forum/ninjatrader-8/strategy-development/1149892-how-to-optimize-a-time-period-from-xy-to-xy-what-is-the-best-entry-and-exit-time#post1150007

I appreciate your patience. Please let us know if we may be of further assistance.