Fresh eyes needed for rucursive method

[Chippy]

My coding skills are pretty rusty. Can someone find the error in the recursive method HighIn().

private int firstRun=0;

protected override void OnBarUpdate(){
   if(firstRun<15){
      firstRun++;
   return;
   }

   Print(HighIn(3));
}

private double HighIn(int bars){
   if(bars <= 2){
       return High[bars];
   }
   double value = HighIn(bars--);
   if(value>High[bars]){return value;}else{ return High[bars];}
}

[Chippy]

It compiles fine, but crashes NT when I try to run it in the strategy analyzer.

[SuneSorgenfrei]

Hi
So first and foremost the -- in

bars--

is not decrementing right away
Example

int i = 3;
Console.WriteLine(i); // output: 3
Console.WriteLine(i--); // output: 3
Console.WriteLine(i); // output: 2

So you would need to use --bars

I would introduce an extra variable though to keep the value of --base to have control and make debugging easier.

[NinjaTrader_Jesse]

Hello Chippy,

If the method crashes the platform that means you entered an infinite loop. You would need to use prints to identify what the problem is with the way you have called the method recursively. One problem may be that you are trying to decrement a passed in variable. I am not sure what your goal was with the method to comment on a possible solution however using a Print with the variables you are using should help to identify what the problem is before the crash.

If possible I would suggest to avoid recursive functions and use a standard finite for loop.

Please let me know if I can be of additional help.

[Chippy]

SuneSorgenfrei..... thank you, that did it. I've spent hours trying to find it. I originally downloaded VS 2022 which NT apparently can't launch so I couldn't debug. I'm currently DL'ing 2019. Stepping through the code would have been a big help.

[Chippy]

Jesse, "print" doesn't help much if it crashes. It was indeed an infinite loop. Simply having the decrement after the variable instead of before was the problem. Credit and thanks to SuneSorgenfrei for finding it.