How to Save / Restore two InstrumentSelector values

[jleira]

Hello

I want to be able to save and restore 2 instrumentselectors that I keep in an addons that I am developing, but when I open the addons, only the value of one of them is restored in both instrumentselectors. Could you give me a nudge with the logic that I must follow in order to be able to save and restore both Selectors separately?

 protected override void Restore(XElement element)
{
if (element == null)
return;

// Restore the Second selected instrument
XElement instrumentElement = element.Element("Instrument");
if (instrumentElement != null && !string.IsNullOrEmpty(instrumentElement.Value))
Instrument = Cbi.Instrument.GetInstrument(instrumentElement.Value);

[SIZE=14px][B]// Restore the Second selected instrument
XElement instrumentElementMaster = element.Element("InstrumentMaster");
if (instrumentElementMaster != null && !string.IsNullOrEmpty(instrumentElementMaster.Value))
InstrumentMaster = Cbi.Instrument.GetInstrument(instrumentElementMast er.Value);[/B][/SIZE]
}

protected override void Save(XElement element)
{
if (element == null)
return;

// Save the First selected instrument
if (Instrument != null)
element.Add(new XElement("Instrument") { Value = Instrument.FullName });

[SIZE=14px][B]// Save the Second selected instrument
if (InstrumentMaster != null)
element.Add(new XElement("InstrumentMaster") { Value = InstrumentMaster.FullName.ToString() });[/B][/SIZE]

I don't get any error, just when I close and open the addons the second selector is restored with the value of the first selector. The second instrument selector works correctly and I have already tried it, all I want is to restore the value that was selected before closing the addons.

[NinjaTrader_ChrisL]

Hello jleira, thanks for your post.

The element looks like it's not being saved properly when Save() is called. Have you confirmed what the value of InstrumentMaster.FullName.ToString() is when Save() is called? If you could make a reduced example addon with only the two instruments and demonstrates the issue I can test it out on my end to see what the problem is after you have fonfirmed what InstrumentMaster.FullName is.

Best regards,
-ChrisL

[jleira]

Hello NinjaTrader_ChrisL

I have done the test you indicated and I see that Instrument.Fullname and InstrumentMaster.Fullname keep their own values separately. Attached photo of Output 1.

I share a reduced code with you.

[ATTACH]n1147212[/ATTACH]

[NinjaTrader_ChrisL]

Hello jleira, thanks for posting the reduced sample. I am able to save the selected instrument for each Instrument selector in the workspace. Are you getting something different testing this reduced script? If so please first make sure you are running the latest version of NinjaTrader by running the installer from this page:

https://ninjatrader.com/GetStarted

I look forward to hearing from you.

[jleira]

Hello

It just can not be. It does not work for me. For example if I open the testAddons and in either of the two selectors I change the instrument, save the workspace and close the testAddons, when I open the testAddons again, in both selectors the instrument that had changed is restored and I do not want that but in each selector The instrument that was selected before closing the testAddons is restored.

I already have the latest version of NinjaTrader 8.0.24.1

Did each selector restore you with a different instrument?

[NinjaTrader_ChrisL]

Hello jleira, thanks for your reply.

The workspace will save the values that you set from the single window instance. If you close out the window instance and start a new one it would go back to the default values. If you exit NinjaTrader with the same window instance it will keep the selected value. If you need some templating system where a default template is loaded every time you open a new window that would need to be implemented as a feature of your addon, there's is no helper code for templates in the addon framework.

Please let me know if this does not resolve your inquiry.

[jleira]

Hi ChrisL

I don't think you understood the problem I was having. What was happening is that if you had made a change in an instrument selector before closing the addon window, that same instrument was restored in both instrument selectors when you opened the addon window again and that was wrong.

But I found something on the instrument selector line in the XAML file. LastUsedGroup = "AddOnFramework". Both instrument selectors showed the same name "AddOnFramework" so I changed the name of each one.
This solved the issue and now, if I close the Addon window and reopen it, each instrument selector is restored separately with the instrument it had before it was closed.