AND operator not working as expected

[kdw2493]

Hi,

Please can someone help here, I think my sanity is starting to leave me. I have a strategy that I am busy coding and everything seemed to working ok right up until the point that the AND (&&) operator stopped functioning as expected.

Basically, I have a procedure to check a bunch of parameters and if they all evaluate to TRUE then go long. If any of the checks evaluate to FALSE, no signal is produced.

The code is pretty simple

if (bolOK && atrOK &&  adxOK && riskOK);
{
	Print("Long Signal Triggered");
	Signal = 1;
}
return Signal;

I have debugged this is Visual Studio and I can see that even though some of those checks evaluate to FALSE, it still returns 1

Is this a known problem or am I doing something stupid?

Thanks a lot
Kevin

[NinjaTrader_ZacharyG]

Hello Kevin,

Thank you for your inquiry.

It looks like you have a semicolon after your if condition. Basically, this if condition won't do anything as you haven't specified logic for it to run if it evaluates to true. You'll want to remove the semicolon and then the logic you've provided will only run if your condition is true.

if (bolOK && atrOK &&  adxOK && riskOK) // no semicolon
{
	Print("Long Signal Triggered");
	Signal = 1;
}
return Signal;

Please, let us know if we may be of further assistance.

[kdw2493]

Zachary,

Thanks very much for the very fast reply. That was exactly the problem. 1 errant semi-colon....

Thanks a lot!