Initialize Trailing Stop After Other Order Triggered

[jg123]

Hello

I am noticing an error in one of my strategies.

Currently the trailing stop is being initilized too soon.

Two IOrder exit variables are called
LongLimit & ShortLimit.

The Trailing stop is to be initilized after one of these two orders are triggered and executed.

Currently, in OnBarUpdate() I have this:

			// Long SMA Trailing Stop
			if (BarsInProgress == 1)
			{
				if (Close[0] > SMA(BarsArray[0], sMAPeriod)[0]+((signalHigh-signalLow)*StopPerc))
				
				{
					adjustedStopLong = SMA(BarsArray[0], sMAPeriod)[0]-((signalHigh-signalLow)*StopPerc);
					LongStopB = ExitLongStop(0,true,DefaultQuantity,SMA(BarsArray[0], sMAPeriod)[0] - ((signalHigh-signalLow)*StopPerc),"LongBStop","LongEntryB");
				}
				
			// Short SMA Trailing Stop
				if (Close[0] < SMA(BarsArray[0], sMAPeriod)[0] + ((signalHigh-signalLow)*StopPerc));
				{
					adjustedStopShort = SMA(BarsArray[0], sMAPeriod)[0] + ((signalHigh-signalLow)*StopPerc);
					ShortStopB = ExitLongStop(0,true,DefaultQuantity,SMA(BarsArray[0], sMAPeriod)[0] + ((signalHigh-signalLow)*StopPerc),"ShortBStop","ShortEntryB");
				}
			}

But what i am thinking that I should do is move this code to OnExecution() and do something like this:

if (LongLimit != null
     && LongLimit = execution.Order)
{ 
     			// Long SMA Trailing Stop
			if (BarsInProgress == 1)
			{
				if (Close[0] > SMA(BarsArray[0], sMAPeriod)[0]+((signalHigh-signalLow)*StopPerc))
				
				{
					adjustedStopLong = SMA(BarsArray[0], sMAPeriod)[0]-((signalHigh-signalLow)*StopPerc);
					LongStopB = ExitLongStop(0,true,DefaultQuantity,SMA(BarsArray[0], sMAPeriod)[0] - ((signalHigh-                       signalLow)*StopPerc),"LongBStop","LongEntryB");
				}
}

Can you just confirm if I am thinking correctly with this? Getting into trailing stops and multi-time frame coding seems to get pretty confusing for me pretty quickly.

Thanks

[koganam]

Hello

I am noticing an error in one of my strategies.

Currently the trailing stop is being initilized too soon.

Two IOrder exit variables are called
LongLimit & ShortLimit.

The Trailing stop is to be initilized after one of these two orders are triggered and executed.

Currently, in OnBarUpdate() I have this:

            // Long SMA Trailing Stop
            if (BarsInProgress == 1)
            {
                if (Close[0] > SMA(BarsArray[0], sMAPeriod)[0]+((signalHigh-signalLow)*StopPerc))
                
                {
                    adjustedStopLong = SMA(BarsArray[0], sMAPeriod)[0]-((signalHigh-signalLow)*StopPerc);
                    LongStopB = ExitLongStop(0,true,DefaultQuantity,SMA(BarsArray[0], sMAPeriod)[0] - ((signalHigh-signalLow)*StopPerc),"LongBStop","LongEntryB");
                }
                
            // Short SMA Trailing Stop
                if (Close[0] < SMA(BarsArray[0], sMAPeriod)[0] + ((signalHigh-signalLow)*StopPerc));
                {
                    adjustedStopShort = SMA(BarsArray[0], sMAPeriod)[0] + ((signalHigh-signalLow)*StopPerc);
                    ShortStopB = ExitLongStop(0,true,DefaultQuantity,SMA(BarsArray[0], sMAPeriod)[0] + ((signalHigh-signalLow)*StopPerc),"ShortBStop","ShortEntryB");
                }
            }

But what i am thinking that I should do is move this code to OnExecution() and do something like this:

if (LongLimit != null
     && LongLimit = execution.Order)
{ 
                 // Long SMA Trailing Stop
            if (BarsInProgress == 1)
            {
                if (Close[0] > SMA(BarsArray[0], sMAPeriod)[0]+((signalHigh-signalLow)*StopPerc))
                
                {
                    adjustedStopLong = SMA(BarsArray[0], sMAPeriod)[0]-((signalHigh-signalLow)*StopPerc);
                    LongStopB = ExitLongStop(0,true,DefaultQuantity,SMA(BarsArray[0], sMAPeriod)[0] - ((signalHigh-                       signalLow)*StopPerc),"LongBStop","LongEntryB");
                }
}

Can you just confirm if I am thinking correctly with this? Getting into trailing stops and multi-time frame coding seems to get pretty confusing for me pretty quickly.

Thanks

If you wish to perform an action based on execution of an order, they you should be using the OnExecution() event handler.

[NinjaTrader_PatrickH]

Hello jg123,

Thank you for your post.

OnExecution() is the correct way to go about it. A trailing stop needs to trail during price updates, OnExecution() only calls during executions. So you may wish to set a variable in OnExecution when the entries are executed and then check for this variable in OnBarUpdate() to set the trailing stop. When the stop executes set the variable back to it's original value.

Please let me know if you have any questions.