The Various OrderStates OnExecution() Method tracks?

[piyushc]

Can we use try catch to debug OnOrderUpdate() ?

[NinjaTrader_ChelseaB]

Hi piyushc,

A try and catch can be really helpful sometimes.

I personally prefer to add prints before whatever condition or loop i'm about to run.

To debug your code I started by adding prints and returns to test small bits of the code at a time.

I think I see the issue and this issue would not be prevented with a try and a catch because the issue does not cause an error but instead causes NinjaTrader to crash.

The issue is that you are running ChangeOrder inside of OnOrderUpdate and you are changing the order that triggered OnOrderUpdate.

Changing an order will cause OnOrderUpdate to run on that order. You are once again causing an endless loop.

This endless loop will not throw an error because technically sometimes its needed to do this. But thats the same with a while loop. Sometimes its needed to use a while loop. But if your loop never ends, it will crash the program it is running in no matter what programming language you are using.

You call OnOrderUpdate and then call ChangeOrder which calls OnOrderUpdate which calls ChangeOrder which calls OnOrderUpdate.. etc, forever until NinjaTrader crashes.

While using ChangeOrder inside of OnOrderUpdate is necessary sometimes, like to change a stop loss or profit target, you will need to make sure that you are not changing the order that triggered OnOrderUpdate. OR you can use a bool to make sure that is it run once.

Changing an order the very second it is placed does not sound like good code in the first place, however. If you are wanting to trail an order, OnOrderUpdate does not sound like the place for it. You may want to look at the logic you have and double check that this is what you want to be doing.

[piyushc]

Thank you for your exhaustive effort & insight.
Let me think it through & will come back after making necessary changes to the code.