lastTrade

[Tdschulz]

I am attempting to implement some money management approaches within my strategy but can not seem to get it. For simplicity, let's say I just want to check whether the last trade was a winner or looser. What is wrong with this code?

if (Performance.AllTrades.Count > 1)

   			 {

        		Trade lastTrade = Performance.AllTrades[Performance.AllTrades.Count - 1];

				double lastProfit = lastTrade.ProfitCurrency*lastTrade.Quantity;
 
        		Print("The last trade profit is " + lastProfit);


   			 }

            // Condition set 1
            if (
				lastProfit > 0
				&& Close[0] == High[0]
                
				)
            {
                EnterLongLimit(1, Close[0] + 1 * TickSize, "LongEntry");
            }

[NinjaTrader_Joydeep]

Hello Tdschulz,
The trade collection will add an object to it only when you have a trade. However a trade will never occur since your coding filter specifies lastProfit > 0 (which will never happens unless there is a trade).

Its like a circular reference, and thus you are witnessing the scenario.

double lastProfit = 0;

if (Performance.AllTrades.Count >= 1)

 {
	Trade lastTrade = Performance.AllTrades[Performance.AllTrades.Count - 1];
	lastProfit = lastTrade.ProfitCurrency*lastTrade.Quantity;
	Print("The last trade profit is " + lastProfit);
 }

// Condition set 1
if ((Performance.AllTrades.Count == 0 || lastProfit > 0)
	&& Close[0] == High[0]
    
	)
{
    EnterLongLimit(1, Close[0] + 1 * TickSize, "LongEntry");
}

Please note, if any trade results in a loss you will not have any further trade since lastProfit > 0.

[Tdschulz]

The problem is not that it's not executing as I expected but I can't get it to compile. Error says lastProfit does not exist. Do I need to add that in the Properties section?

[Tdschulz]

Sorry. I didn't set the double = 0; at the beginning. I have it now.

Next issue. The lastProfit is only recording the profit from a single contract rather that the amount for the entire quantity. Do you see anything wrong here?

 protected override void OnBarUpdate()
        {	
			double lastProfit = 0;
			if (CurrentBar < 250)
			{
				return;
			}
			
			if (Performance.AllTrades.Count >= 1)

   			{

        		Trade lastTrade = Performance.AllTrades[Performance.AllTrades.Count - 1];

				lastProfit = lastTrade.ProfitCurrency*lastTrade.Quantity;
 
        		
			}	


   			Print("The last trade profit is " + lastProfit); 

            // Condition set 1
            if ((Performance.AllTrades.Count == 0 || lastProfit > 0)
			
				&& Close[0] == High[0]
                
				)
            {
                EnterLongLimit(1, Close[0] + 1 * TickSize, "LongEntry");
            }
			
			if ((lastProfit < 0 && lastProfit > -140)
			
				&& Close[0] == High[0]
                
				)
            {
                EnterLongLimit(2, Close[0] + 1 * TickSize, "LongEntry");
            }
			if ((lastProfit < -140)
			
				&& Close[0] == High[0]
               
				)
            {
                EnterLongLimit(6, Close[0] + 1 * TickSize, "LongEntry");
            }

[NinjaTrader_Joydeep]

Hello Tdschulz,
Profit for the last trade is taken into account as per the below code.

Performance.AllTrades[Performance.AllTrades.Count - 1]

If you need the total profit then you have to change the above and calculate it further.

[Tdschulz]

isn't that what I'm calculating as:
lastProfit = lastTrade.ProfitCurrency*lastTrade.Quantity;

[NinjaTrader_Joydeep]

Hello Tdschulz,
To assist you further may I know, are you trying to figure out the total profit for the entire period or the profit for the last trade only.

[Tdschulz]

Profit for last trade only

[NinjaTrader_Joydeep]

Hello Tdschulz,
To assist you further may I know, are you getting the trade part-filled?

I look forward to assisting you further.

[Tdschulz]

Full fills. It's occurring in replay and SIM. Maybe there is a better way to accomplish my goal. I want to trade one contract unless I get a looser. If a looser occurs when trading one contract, then trade two on the next trade. If that looses, trade 6 contracts. I was attempting to do that using dollar loss amounts but maybe you know of a better way.

[NinjaTrader_Joydeep]

Hello Tdschulz,
If the trade gets fully filled at one shot then you will get the correct volume.

What value do you get if you print,

Print(lastTrade.Quantity);

[Tdschulz]

If lastTrade.Quantity only looks at the individual fills, then I'll need to figure out another way. Do you have a method to suggest to have the strategy look for a sequence of looses? As I mentioned, my end goal is to increase contracts as looses occur.

[Tdschulz]

I tried Printing lastTrade.Quantity and I receive an error stating 'lastTrade' does not exist in the current context. It compiles fine when used in the lastProfit statement but gives an error when trying to print it. Any ideas?

[Radical]

I tried Printing lastTrade.Quantity and I receive an error stating 'lastTrade' does not exist in the current context. It compiles fine when used in the lastProfit statement but gives an error when trying to print it. Any ideas?

It might help if you posted the bit of code that you're having trouble with.

[NinjaTrader_Joydeep]

Hello Tdschulz,
The trade collection is the best way to retrieve the PnL.

As an alternative you can store the positions PnL in a variable when you are in a position and use it later to determine the quantity size.

Position.GetProfitLoss(...)

http://www.ninjatrader.com/support/helpGuides/nt7/index.html?getprofitloss.htm