How Can I Learn to Use Methods

[Gennaker]

Support Forum,

I'm working on my first strategy and am coming up with a lot of CS1525 error codes.

if (Close[0] > Open[0] && (Open[0] - Low[0]) >= (Close[0] - Open[0]) * wickMultiplier && (High[0] - Close[0])<= (High[0] - Low[0])* bodyPercentage)
&& (High[0] >= pp - near * TickSize && High[0] <= pp + near * TickSize )
EnterLong();

Where can I to learn how to break this up into method statements? I tried following a couple of the NinjaScript manual examples but they don't seem to work and I'm not sure if I am even putting them in the right section.

Thanks,
Gennaker

[NinjaTrader_Joydeep]

Hello Gennaker,
Thanks for writing in and I am happy to assist you.

Please add a round bracket before and at the end of the if statement

if [B][COLOR="Blue"]([/COLOR][/B](Close[0] > Open[0] && (Open[0] - Low[0]) >= (Close[0] - Open[0]) * wickMultiplier && (High[0] - Close[0])<= (High[0] - Low[0])* bodyPercentage) && (High[0] >= pp - near * TickSize && High[0] <= pp + near * TickSize )[B][COLOR="blue"])[/COLOR][/B]
				EnterLong();

Please let me know if I can assist you any further.

[Gennaker]

Thanks Joydeep,

That took care of the error messages I was receiving. Now that it is working, I would like to know how I can split this code into two methods earlier on in the strategy and be able to call them in the OnBarUpate() section.

I would like to call the first method (I hope I am using the correct terminology) "WickReversal1" and would consist of

(Close[0] > Open[0] && (Open[0] - Low[0]) >= (Close[0] - Open[0]) * wickMultiplier && (High[0] - Close[0])<= (High[0] - Low[0])* bodyPercentage)

I would like to call the second method "NearPivot" and consists of

(High[0] >= pp - near * TickSize && High[0] <= pp + near * TickSize )

Then I would like to be able to just say within the OnBarUpdate section:

if WickReversal1 && NearPivot
EnterLong();

Can you show me how to do this?

Thanks,
Gennaker

[NinjaTrader_Joydeep]

Hello Gennaker,
The code I shown before essentially does what you want to do

if ((Close[0] > Open[0] && (Open[0] - Low[0]) >= (Close[0] - Open[0]) * wickMultiplier && (High[0] - Close[0])<= (High[0] - Low[0])* bodyPercentage) && (High[0] >= pp - near * TickSize && High[0] <= pp + near * TickSize ))
				EnterLong();

Alternatively you can also write it as

if (Close[0] > Open[0] && (Open[0] - Low[0]) >= (Close[0] - Open[0]) * wickMultiplier && (High[0] - Close[0])<= (High[0] - Low[0])* bodyPercentage)

{
   if (High[0] >= pp - near * TickSize && High[0] <= pp + near * TickSize )
   {
	EnterLong();
   }
}

Both the code check for the first condition (WickReversal1) and if its true then it checks for the second condition (NearPivot). If both the conditions are true then a long market order is placed.

Please refer to our help files in the below link which explains some basic programming concepts http://www.ninjatrader.com/support/h...g_concepts.htm

Please let me know if I can assist you any further.

[Gennaker]

Joydeep,

In the link you provided there is a section called "Functions and Methods Explained". In that section, there is an example of what I am trying to do. It declares a method called "AverageRange ()" and uses it later on in the script.

That is what I am trying to learn how to do. I want to declare WickReversal1 as a method and NearPivot as a method earlier in the script. I then want to reference them both later to execute a EnterLong () command.

Thanks,
Gennaker

[NinjaTrader_Joydeep]

Hello Gennaker,
Thanks for the clarification.

This is more of a C# concept and beyond what we could support. However a basic code will look like

private bool WickReversal1()
{
    //logic for the wick reversal
}

private bool NearPivot()
{
    //logic for the near suppot
}

//call the functions in OnBarUpdate as
public override void OnBarUpdate()
{
    if (WickReversal() && NearPivot())
    {
           EnterLong();
     }
}

To learn more on functions please refer here http://csharp.net-tutorials.com/basics/functions/

Please let me know if I can assist you any further.

[Gennaker]

Joydeep,

That helps. I was using Private Void and not Private Bool.

Should these methods be declared in the Initialize () section or does it matter where?

Thanks,
Gennaker

[NinjaTrader_Joydeep]

Hello Gennaker,
Glad to know you are able to get the concepts.

These are functions and you basically call it. You dont have to "declare" it.

For example a basic indicator class will look like

public MyIndicator : Indicator
{

   public override void Initialize()
   {
       //codes
    }

   public override void OnBarUpdate()
   {
          //you can call the private fuctions in OnBarUpdate
          if (WickReReversal1() && NearPivot())
           {
               EnterLong();
           }
    }

   private bool WickReversal1()
   {
           //codes
   }

   private bool NearPivot()
   {
        //codes
   }
}

Please let me know if I can assist you any further.

[Gennaker]

Joydeep,

I tried calling the private functions as you suggested, but got a couple of errors when I did the following:

protectedoverridevoid OnBarUpdate()
{

privatebool WickReversal1()
{
(Close[0] > Open[0] && (Open[0] - Low[0]) >= (Close[0] - Open[0]) * wickMultiplier && (High[0] - Close[0])<= (High[0] - Low[0])* bodyPercentage);
}
//other codes that didn't produce errors before adding this snippet
}




The first error was a "statement expected" on the same line as the first curly brace (}) below the OnBarUpdate () line.

The second error was a " ; expected" at the end of the WickReversal1 () line.

Would appreciate your advice.

Thanks,
Gennaker

[NinjaTrader_Joydeep]

Hello Gennaker,
You are defining the function inside the OnBarUpdate method.

You can only call the function in OnBarUpdate method. You have to define it outside OnBarUpdate.

Please refer here to get more ideas on Functions and Methods

http://msdn.microsoft.com/en-us/library/ms173114(v=vs.80).aspx

Please let me know if I can assist you any further.

[koganam]

Joydeep,

I tried calling the private functions as you suggested, but got a couple of errors when I did the following:

protectedoverridevoid OnBarUpdate()
{

privatebool WickReversal1()
{
(Close[0] > Open[0] && (Open[0] - Low[0]) >= (Close[0] - Open[0]) * wickMultiplier && (High[0] - Close[0])<= (High[0] - Low[0])* bodyPercentage);
}
//other codes that didn't produce errors before adding this snippet
}




The first error was a "statement expected" on the same line as the first curly brace (}) below the OnBarUpdate () line.

The second error was a " ; expected" at the end of the WickReversal1 () line.

Would appreciate your advice.

Thanks,
Gennaker

In addition to what NinjaTrader_Joydeep says below, your method is defective anyway. You specify that the method should return a bool value, but you are not returning anything in the body of the function. Try this:

 
private bool WickReversal1()
{
bool testValue = false;
testValue = ((Close[0] > Open[0] && (Open[0] - Low[0]) >= (Close[0] - Open[0]) * wickMultiplier && (High[0] - Close[0])<= (High[0] - Low[0])* bodyPercentage));
return testValue;
}

[Gennaker]

Thanks, Koganam. That was helpful. Looking forward to trying it next week after my holiday.