Offset doesn't work

[trend747]

I simply want to trigger a short when price moves X ticks on close past an EMA.

It won't work...it just enters immediately when the bar closes. This is for USD/JPY on forex. I've been sitting here banging my head on the table for hours. I'm completely new to NinjaTrader so I'm sure it's something simple.

// Condition set 1
if (Open[0] + 8 * TickSize > EMA(23)[0])
{
EnterShort(Lots, "");
}

[koganam]

... price moves X ticks on close past an EMA.

Then you should be referring to Close[0], which is the close of the bar that just closed, not Open[0] which is the Open of the bar that just closed.

That is, unless you are using CalculateOnBarClose = false; in your Initialize() method, in which case you can use either Open[0] or Close[1], which on most bar types are equivalent, most of the time.

[NinjaTrader_Matthew]

trend747,

Thank you for your post.

koganam would be correct here. If you would like to enter after X ticks from the open of the current bar, please make sure your strategy is using CalculateOnBarClose = false;

You can either set this property in the Initialize() method from your code, or when adding the strategy you will see an option to manually set the CalulateOnBarClose to false.

Please review our Help Guide article on the COBC property for more information:

http://www.ninjatrader.com/support/helpGuides/nt7/index.html?calculateonbarclose.htm

I would also suggest taking a look at our strategy reference sample for 'Separating logic to either calculate once on bar close or on every tick':

http://www.ninjatrader.com/support/forum/showthread.php?t=19387

[trend747]

Then you should be referring to Close[0], which is the close of the bar that just closed, not Open[0] which is the Open of the bar that just closed.

That is, unless you are using CalculateOnBarClose = false; in your Initialize() method, in which case you can use either Open[0] or Close[1], which on most bar types are equivalent, most of the time.

I tried that as well. It still immediately opens a trade.

[trend747]

It also immediately tries to enter a trade as soon as I start the replay... so you then get an error, "There is no market data ..." So something is clearly wrong.

[NinjaTrader_Matthew]

trend747,

Can you clarify the calculate on bar close value you are using? What happens when you use COBC to true? Does the trade still execute when enabling? Or do you get the results you are looking for?

[trend747]

trend747,

Can you clarify the calculate on bar close value you are using? What happens when you use COBC to true? Does the trade still execute when enabling? Or do you get the results you are looking for?

COBC is true. Here's the code:

// Condition set 1
if (Close[0] + 0.1 > EMA(23)[0])
{
EnterShort(Lots, "");
}

To me, this says, "If the close of the bar is more than 10 pips greater than the EMA, then enter short"

It doesn't do that...

[NinjaTrader_Matthew]

Hello,

I would suggest adding some Print() functions to help determine the value that logic is actually using vs the logic you intend to use.

More information on debugging your NinjaScript code from the following link:

http://www.ninjatrader.com/support/forum/showthread.php?t=3418

[trend747]

I just tried:

// Condition set 1
if (Close[0] > EMA(23)[0]) + 0.8
{
EnterShort(Lots, "");
}

...and it seems to be working correctly.

[koganam]

COBC is true. Here's the code:

// Condition set 1
if (Close[0] + 0.1 > EMA(23)[0])
{
EnterShort(Lots, "");
}

To me, this says, "If the close of the bar is more than 10 pips greater than the EMA, then enter short"

It doesn't do that...

Actually that says: "If the close of the bar is smaller than the EMA by less than 10 pips, then enter short." Not quite the same thing.

[trend747]

I think I got it figured out. Thanks everyone for the great support.