Cancel Order Using Managed Approach

[Baseheadz]

I put together some code and I wanted to see if this was looking correct as it is the very first time that I'm using the LiveUntilCancelled and CancelOrder approach. IOrder is not highlighted in blue in my strategy and I'm wondering if CancelOrder needs {} around it. Thanks!


#region variables
private IOrder myEntryOrder = null; //IOrder is NOT HIGHLIGHTED IN BLUE like in the help guide
private int barNumberOfOrder = 0;
private int ProfitTarget = 10;
private int stoplossticks = 10;

protected override void Initialize()
//PROFIT TARGET AND STOP LOSS
{
SetProfitTarget("", CalculationMode.Ticks, ProfitTarget);
SetStopLoss("", CalculationMode.Ticks, stoplossticks, false);
CalculateOnBarClose = true;
}

protected override void OnBarUpdate()
{

if ((myEntryOrder == null)
&& CrossAbove(Close, EMA(LengthMA), 1)

{
EnterLongLimit(0, true, DefaultQuantity, Close[0], "Long Limit");
barNumberOfOrder = CurrentBar;
}

if ((myEntryOrder == null)
&&CrossBelow(Close, EMA(LengthMA), 1)
{
EnterShortLimit(0, true, DefaultQuantity, Close[0], "Short Limit");
barNumberOfOrder = CurrentBar;
}


//Cancels Limit order I don't seem to need {} for the CancelOrder???????????????
if (CurrentBar > barNumberOfOrder + 4)
CancelOrder(myEntryOrder);


}

[NinjaTrader_Austin]

baseheadz, if statements will always execute the first line of code following the statement (if the condition is true), but if you have more than one line after an if statement, you'll need the brackets.

if (true)
x = 1; // this will work since there is only one line

if (true)
x = 1;
y = 2; // this would run whether or not the if statement is true

if (true)
{
x = 1;
y = 2; // this will run as part of the if statement
}

[Baseheadz]

Thanks Austin. Does everything else look good in the code that I posted?

[NinjaTrader_Austin]

I took a quick look and everything else seems like it is correct. You'll have to test it to find out 100% though. Please let me know if you have any other questions.

[Baseheadz]

Austin,

The last bit of code is giving me an error when I load the strategy:
Error on calling OnBarUpdate method for Strategy: Object reference not set to an instance of an object.

I narrowed down the code which is causing the error by commenting out the lines below, but I can't figure out why I'm generating the error:

//Cancels Limit order
if (CurrentBar > barNumberOfOrder + 5)
CancelOrder(myEntryOrder);

[Baseheadz]

I realized that I did not have "myEntryOrder =" in front of EnterLongLimit and EnterShortLimit. But when I added those, I still got the same exact error.

[Baseheadz]

Ok... I think I have it fixed. I realized that I had to check for myEntryOrder to by null, and I also had to reset myEntryOrder back to null.

Does this look ok????????

if ((myEntryOrder != null) &&(CurrentBar > barNumberOfOrder + 7))
{
CancelOrder(myEntryOrder);
myEntryOrder = null;
}

[NinjaTrader_Austin]

Baseheadz, please see the help guide entry for IOrders for how to submit, use, and reset IOrders.

[Baseheadz]

I'm a little confused on this and I can not find any examples that help with Canceling the order.
Can I make myEntryOrder = null in the OnOrderUpdate like I have done?


In the OBU
//Cancels Limit order************************************
if ((myEntryOrder != null) &&(CurrentBar > barNumberOfOrder + 7))
{
CancelOrder(myEntryOrder);

}

protected override void OnOrderUpdate(IOrder order)
{
if ((myEntryOrder != null) &&(CurrentBar > barNumberOfOrder + 7))
{
myEntryOrder = null;
}

if (Position.MarketPosition != MarketPosition.Flat)
{
myEntryOrder = null;
}
}

[NinjaTrader_RyanM1]

Hi Baseheadz,

We have a sample available for CancelOrder() here:

http://www.ninjatrader.com/support/forum/showthread.php?t=18890

You want to set the order back to null when either it's filled or cancelled.

[Baseheadz]

Right, I have found a couple of example of how to reset back to null when the order is cancelled, but there are no examples of how to do this when the order is filled.

[NinjaTrader_RyanM1]

It's the same, only you check filled order state along with cancelled. Example:

if (order.OrderState == OrderState.Cancelled || order.OrderState == OrderState.Filled)
entryOrder = null;

Another example on this page:

http://www.ninjatrader.com/support/helpGuides/nt7/iorder.htm

[Baseheadz]

strike my last comment.

Here is what I understand. I am using the managed approach. Is this looking ok?


protected override void OnOrderUpdate(IOrder order)
{
if (myEntryOrder != null && myEntryOrder == order)
{
// Reset the entryOrder object to null if order was filled OR order was cancelled without any fill
if (order.OrderState == OrderState.Filled || order.OrderState == OrderState.Cancelled)
{
myEntryOrder = null;
}
}

}

[NinjaTrader_RyanM1]

Yes, that looks correct.

[Baseheadz]

Thank you. Just to clarify, what exactly does this mean:
myEntryOrder == Order