I am very new to Ninja Script and not a programmer. I have tried to build a simple trailing stop strategy that would trigger trades and exits at points of bar close only (not intrabar like normal stops etc.). Predictably, I am running into some problems and have included the code shown below. Any suggestions would be greatly appreciated. Thanks.
Code:
// This namespace holds all strategies and is required. Do not change it.
namespace NinjaTrader.Strategy
{
/// <summary>
/// Enter the description of your strategy here
/// </summary>
[Description("Auto adjusted stops. ProfTgt1BE=level Stop reset to BE. ProfTgt2= level Stop reset to Stop2.")]
public class demaRenkoTrlStp : Strategy
{
#region Variables
// Wizard generated variables
private int dEMA1 = 1; // Default setting for DEMA1
private int dEMA2 = 1; // Default setting for DEMA2
private int trailStop = 1; // Default setting for ProfTgt1BE
private int maxPriceLong = 0;
private int maxPriceShort = 500;
// User defined variables (add any user defined variables below)
#endregion
/// <summary>
/// This method is used to configure the strategy and is called once before any strategy method is called.
/// </summary>
protected override void Initialize()
{
Add(DEMA(DEMA1));
Add(DEMA(DEMA2));
CalculateOnBarClose = true;
}
/// <summary>
/// Called on each bar update event (incoming tick)
/// </summary>
protected override void OnBarUpdate()
{
// Resets the stop loss to the original value when all positions are closed
if (Position.MarketPosition == MarketPosition.Flat)
{
maxPriceLong = 0;
maxPriceShort = 500;
}
// If a long position is open, begin calculation for trail stop
else if (Position.MarketPosition == MarketPosition.Long)
{
// Update maxPrice
if (Close[0] > maxPriceLong)
{
maxPriceLong = Math.Max(maxPriceLong, Close[0]);
}
// Once the close gets to or below trail stop, exit
if (Close[0] <= maxPriceLong - trailStop * TickSize)
{
ExitLong(DefaultQuantity,"") ;
}
}
// If a short position is open, begin calculation for trail stop exit
else if (Position.MarketPosition == MarketPosition.Short)
{
// Update maxPrice
if (Close[0] < maxPriceShort)
{
maxPriceShort = Math.Min(Close[0], maxPriceShort);
}
// Once the clsoe gets above position trail stop, exit
if (Close[0] >= maxPriceShort + trailStop * TickSize)
{
ExitShort(DefaultQuantity, "");
}
}
// Condition set 1
if (CrossAbove(DEMA(DEMA1), DEMA(DEMA2), 1))
{
EnterLong(DefaultQuantity, "RTS");
}
// Condition set 2
if (CrossBelow(DEMA(DEMA1), DEMA(DEMA2), 1))
{
EnterShort(DefaultQuantity, "RTS");
}
}
#region Properties
[Description("")]
[GridCategory("Parameters")]
public int DEMA1
{
get { return dEMA1; }
set { dEMA1 = Math.Max(1, value); }
}
[Description("")]
[GridCategory("Parameters")]
public int DEMA2
{
get { return dEMA2; }
set { dEMA2 = Math.Max(1, value); }
}
[Description("")]
[GridCategory("Parameters")]
public int TrailStop
{
get { return trailStop; }
set { trailStop = Math.Max(1, value); }
}
#endregion
}
}
Comment