SampleOnOrderUpdate

[AnotherTrader]

Almost certainly a misunderstanding on my part, but I would be grateful for clarification of the following, please.

The SampleOnOrderUpdate code example contains the following code fragment:

 
// Resets the entryOrder object to null after the order has been filled 
// or partially filled
 
if (execution.Order.OrderState != OrderState.PartFilled)
{
entryOrder = null;
}

Is this fragment correct?

Shouldn't it be ....

 
// Resets the entryOrder object to null after the order has been filled 
// or partially filled
 
if (execution.Order.OrderState == OrderState.Filled 
|| execution.Order.OrderState == OrderState.PartFilled)
 
{
entryOrder = null;
}

[NinjaTrader_Bertrand]

Thanks for spotting, I believe you're correct - will confirm with the author next week.

[NinjaTrader_JoshP]

Comment should read "has been filled" without the "or partially filled" part. The code is already within a context that checks for filled and therefore we use != so we are truly looking at a filled state.

[AnotherTrader]

Many Thanks!