Exits not functioning properly

[toptrader]

I have written some code that uses a start time and end time to establish trading hours for the day. After my end time, I want to exit all positions. I am using the code below, but it is only functioning properly 50-75% of the time. Any ideas why?

private double starttime = 170000;
private double stoptime = 160000;

bool tradingtime = (starttime<stoptime && t>=starttime && t<stoptime) || (starttime>stoptime && (t>=starttime || t<stoptime)) || starttime==stoptime;

if (Positions[0].MarketPosition==MarketPosition.Long)
{
if (!tradingtime)
	ExitLong("EODLX","LE");
}

My entry is named "LE", so the order is definitely linked properly.

[NinjaTrader_Bertrand]

toptrader, on which instrument and timeframe are you working with this?

How did you define 't'?

Did you take a look already at this sample for time filter examples?

http://www.ninjatrader-support2.com/vb/showthread.php?t=3226

[toptrader]

Sorry I forgot that part.

double t = ToTime(Time[0]);

[NinjaTrader_Bertrand]

ToTime() returns an int, so please try with -

int t = ToTime(Time[0]);

[toptrader]

Bertrand,
I tried that and still got the same issue. Does it make a difference that I am running the strategy on Range charts?

[NinjaTrader_Bertrand]

Yes, as the needed timestamp granularity may not be present on those - suggest you add 1 minute series to the strategy and work with Times then for the checks.

http://www.ninjatrader-support.com/HelpGuideV6/Times.html

[toptrader]

Even when running with CalculateOnBarClose=false?

[NinjaTrader_Bertrand]

Yes, this has no influence on the way you access the historical time stamp values - either there's one present or not, thus your conditions evaluate to true or not. I would suggest you break down your time filer rule in parts and add for example draw statements when it triggers so you have visual confirmation of what to expect from it.