Announcement

Collapse
No announcement yet.

Partner 728x90

Collapse

Logic Error

Collapse
X
 
  • Filter
  • Time
  • Show
Clear All
new posts

    Logic Error

    I'm trying to increase my position size after winning trades. Do you have any idea why the position size won't increase with this code?

    Code:
    public class MyStrategy: Strategy
    {
    private int winloss = 0;
    
            protected override void Initialize()
            { CalculateOnBarClose = true;  }
    
    protected override void OnBarUpdate()
            {
                int lotsize;
                if (winloss > 0)
                {
                    lotsize = Convert.ToInt32(Math.Round(Lots + (Lots * Math.Log(1+winloss))));
                }
                else
                {
                    lotsize = Lots;    
                }
    
    // code to enter long goes here
    
    
                // Condition set 3
                if (an exit long is signaled)
                {
                    winloss = UpdateWL(winloss);
                    ExitLong("", "");
                }
    
            private int UpdateWL(int wl)
            {
                    if (Position.GetProfitLoss(Open[0], PerformanceUnit.Percent) <= 0) // a losing trade
                    { 
                        if (wl  <= 0) { wl--; }
                        else { wl  = -1; }
                    }
                    else // a winning trade
                    { 
                        if (wl >= 0) { wl++;  }
                        else { wl = 1; }
                    }
                    return(wl);
            }
    }

    #2
    In case it's relevant, I'm using the GAIN feed. I took account to round up to whole numbers since that feed supports a minimum unit size of 1.

    Comment


      #3
      texasnomad, I would suggest printing the values to the ouput window (like your winloss and lotsize) to check they actually return what you would expect based on your code logic - http://www.ninjatrader-support2.com/...ead.php?t=3418

      Comment

      Latest Posts

      Collapse

      Topics Statistics Last Post
      Started by Geovanny Suaza, 02-11-2026, 06:32 PM
      0 responses
      649 views
      0 likes
      Last Post Geovanny Suaza  
      Started by Geovanny Suaza, 02-11-2026, 05:51 PM
      0 responses
      370 views
      1 like
      Last Post Geovanny Suaza  
      Started by Mindset, 02-09-2026, 11:44 AM
      0 responses
      109 views
      0 likes
      Last Post Mindset
      by Mindset
       
      Started by Geovanny Suaza, 02-02-2026, 12:30 PM
      0 responses
      574 views
      1 like
      Last Post Geovanny Suaza  
      Started by RFrosty, 01-28-2026, 06:49 PM
      0 responses
      576 views
      1 like
      Last Post RFrosty
      by RFrosty
       
      Working...
      X