MACD crossover above 0 (zeroline)

[visvabalaji]

Hi,

I've been trying to create buy order only when MACD crosses above 0 (zeroline). I'm seeing order is taken when MACD crosses below zeroline also.

In the attachment, red line trade crossed below 0 so it shouldn't have taken. Green line trade is correct as it crosses above 0 line.

Can anyone suggest me to fix this?

if (CrossAbove(MACD(12, 26, 9).Diff, 0, 1))
{
    EnterLong(1, "Buy");
}

if ((CrossBelow(MACD(Close, 12, 26, 9).Diff, 0, 1))
&& (Position.MarketPosition == MarketPosition.Long))
{
    ExitLong(1);
}

[NinjaTrader_Jesse]

Hello visvabalaji,

Are you running the script OnEachTick or OnPriceChange? From the image it is possible that the condition was true and then became false if you were using OnEachTick/PriceChange. With OnBarClose that should be false.

Another factor could be if you manually applied the indicator, you need to make sure the strategy is adding the indicator in order to confirm visually against what the strategy is actually using.

[visvabalaji]

Thanks for your reply. MACD is added through strategy and still getting the same issue. Attached in the latest screenshot from today's emini chart.

Red marked region shouldn't be taken as MACD crosses below 0 line but the trade was taken.
Green marked region is correct as MACD crosses above 0 line.

I think strategy need to find out if the very next bar, after MACD crossover lies under 0, I shouldn't be taken the trade.

Appreciate your help on this.

protected override void OnStateChange()
{
  if (State == State.SetDefaults)
    {
      TimeInForce = TimeInForce.Gtc;
      IsExitOnSessionCloseStrategy = true;
      Calculate = Calculate.OnBarClose;
      ExitOnSessionCloseSeconds = 30;
      OrderFillResolution = OrderFillResolution.Standard;
      RealtimeErrorHandling = RealtimeErrorHandling.StopCancelClose;

      // This strategy has been designed to take advantage of performance gains in Strategy Analyzer optimizations
      // See the Help Guide for additional information
      IsInstantiatedOnEachOptimizationIteration = false;
    }
else if (State == State.DataLoaded)
   {
     MACD1 = MACD(12, 26, 9);
     AddChartIndicator(MACD1);
   }
}

protected override void OnBarUpdate()
{
  if (CrossAbove(MACD(12, 26, 9).Diff, 0, 1))
    {
        EnterLong(1, "Buy");
    }

  if ((CrossBelow(MACD(Close, 12, 26, 9).Diff, 0, 1))
    && (Position.MarketPosition == MarketPosition.Long))
    {
        ExitLong(1);
    }
}

[NinjaTrader_Jesse]

Hello visvabalaji,

It looks like this post involves a script which you have another post open for currently. I would suggest to consolidate the questions for this script into the other post. I provided some debug instructions on how you can use print to observe what values the strategy is seeing. That would be the next step to identify why its conditions are happening at a specific time.

[oldporkchops]

How to I use the GUI Strategy Builder to create a strategy where one of the conditions is where a line crosses over the zero line?