Added Short Side to SampleBreakoutStrategy

[zeller4]

Hello,

I've tried to add a short side condition to the SampleBreakoutStrategy. I wasn't able to get both horizontal lines plotting even though they have unique tags. Haven't run a replay to see if it's taking trades there either.

Not sure if there's other items that would need correcting.

Any help you can give is much appreciated.

Kirk

[NinjaTrader_Ben]

Hello,

I took a quick look at your strategy and I did not see any red flags.

I suggest debugging your code using this link:

http://www.ninjatrader-support2.com/vb/showthread.php?t=3418

[Ralph]

zeller4,

In case Bars.FirstBarOfSession is the lowest low already, you wouldn't see a horizontal line for the lowest low. For this condition you could insert the two DrawHorizontalLine() commands into the "if_(Bars.FirstBarOfSession)_{}" section.

Regards
Ralph

[zeller4]

Ralph, Ben, or whomever can help...

Thanks, I've done that as well as add some print lines to see what's happening. I'm not sure how to reset the BarsSinceEntry to 0 so that there's nothing going on from a previous day. Also, as per the attached screenshot, the low line is not holding to the lowestLow value as the highestHigh is doing...

Any help you can give me is much appreciated.

[Ralph]

Hi zeller4,

had a closer look at your sample. And finally it works as expected.
Here is what I did:

• I commented out the order section of your code, because wanted to deal with the graphics only
• At 3 different occurences you do use if-statements without brackets. Notice this syntax would involve the very next line only.
• At 2 occurences you commented out the DrawHorizontalLine()-commands. I re-animated them.
• I used replay data of a single day for testing. In the strategy setup table I set Min-bars-required to 0, otherwise I would have missed the if-(Bars.FirstBarOfSession)-section of your strategy. I removed the if-(CurrentBar < 10)-command from your code for the same reason.
• I removed the if-(Bars.BarsSinceSession)<30-statement from your code, otherwise I wouldn't have seen the new higher-high-line for my sample data.

Thats all, I attached the chart for my testing.

Regards
Ralph

[zeller4]

Hi Ralph,

I revised most of what you said, thanks for the advice. Not sure what you mean by "strategy setup table" or how to do a Min-bars line...

In the strategy setup table I set Min-bars-required to 0, otherwise I would have missed the if-(Bars.FirstBarOfSession)-section of your strategy. I removed the if-(CurrentBar < 10)-command from your code for the same reason.

Could you please attach a sample of that line or two to show what you mean?

Thanks very much for your help.
Regards,

Kirk

[Ralph]

Hi Kirk,

after opening a chart I can select a strategy by clicking on the $-sign at the top of the chart. Then the setup table shows up. It is the same/similar process as for the strategy analyser back-testing. Please look at the attached JPEG file, the concerning statement is marked red. I also uploaded the strategy file as I used it.

Regards
Ralph

[zeller4]

Ralph,

Thanks very much - I appreciate your improvements and steering me correctly with the if statements with no brackets.

Learned something new today.

Regards,
Kirk

[Ralph]

You are welcome, Kirk. I think it is good practice to think carefully about the initialisation of a strategy, as you could see with this example. Many strategies need to collect some previous bars before starting. So you may not see what you expect to see at the beginning of runtime (i.e. the very first FirstBarOfSession).

Happy coding
Ralph