indicator jumps around ?

[joemiller]

please ignore this thread. I have to fix something then maybe resubmit it

[joemiller]

indicator jumps around

The redline indicator shown in the attachments is a function of the previous bar open and close. Those open and close values never change, yet the last segment of the indicator jumps around as shown in the two attachments. Any comments or suggestions will be appreciated.

[NinjaTrader_Matthew]

Hi joe,

What are you indicator values based on? Do you mean they are Close[1] and Open[1]?

Do you have a sample of code you can post which demonstrates this behavior?

[joemiller]

thanks Matthew

the indicator file is attached.
the code which creates the indicator is as follows:

if(BarsPeriod.Id == PeriodType.Day)//for day bars [don't use GetDayBar for day bars]
{
XXCloseyest=((Open[1]+High[1]+Low[1]+Close[1])*0.25);
XXOpen=((XXCloseyest+XXOpenyest)*0.5);
XXOpenyest=XXOpen; //this will be used on next bar, when at that time it will be XXOpenyest
}

[NinjaTrader_CalH]

Hi Joemiller,

I'm not seeing any errors with the compile and code.

Are you seeing this with all your charts and instruments or just this one in particular?

I see you are using the Print() for your values, are they correct ones being plotted?

What are you setting the Calculate on Bar Close to?

[koganam]

thanks Matthew

the indicator file is attached.
the code which creates the indicator is as follows:

if(BarsPeriod.Id == PeriodType.Day)//for day bars [don't use GetDayBar for day bars]
{
XXCloseyest=((Open[1]+High[1]+Low[1]+Close[1])*0.25);
XXOpen=((XXCloseyest+XXOpenyest)*0.5);
XXOpenyest=XXOpen; //this will be used on next bar, when at that time it will be XXOpenyest
}

XXOpen=((XXCloseyest+XXOpenyest)*0.5);
XXOpenyest=XXOpen; //this will be used on next bar, when at that time it will be XXOpenyest

That block of code, when you use COBC=false, is effectively a loop, changing the value of XXOpenyest on each tick, and hence also changing the value of XXOpen.

Remember that OnBarUpdate(), while an event-handler, is at base, a loop construct. We often forget that the whole paradigm of event-driven programing is to process messages in either a loop, or based on an interrupt scheme.

[joemiller]

damn, I don't have a clue what you said but, no matter, I do think it sounds like I may somehow be able to correct the issue by finding some way to preserve XXOpenyest. because I think I have to Keep COBC = false?

if you guys have any suggestions I will be eternally grateful.

[joemiller]

Cal,
forgot to answer your questions.

Are you seeing this with all your charts and instruments or just this one in particular?
ALL CHARTS

I see you are using the Print() for your values, are they correct ones being plotted?
LOOKS LIKE THEY ARE THE SAME ... THE OUTPUT WINDOW KEEPS UPDATEING WITH INCOMING PRICE FEED.

What are you setting the Calculate on Bar Close to?
DIDN'T KNOW I SHOULD SPECIFY ANYTHNG BEYOND COBC = FALSE?

[NinjaTrader_CalH]

Joemiller,

You can set the indicator to calculate on bar close set to true when you first enable the indicator on the chart.

I will agree with Koganam that your variable is most likely getting reset over and over with the indicator set to false, thus causing the indicator to act the way you see it from the screenshots.

Let me know if I can be of further assistance

[joemiller]

CalculateOnBarClose is set false in the initialize region of the indicator to force last day display of the indicator.

do you mean I should set it to true ... because if I do I think the indictor will not be displayed on the last currently developing bar, which is what I need?

[NinjaTrader_CalH]

Joemiller,

You can try using FirstTickOfBar in your condition to preserve the variable so that it does not keep getting updated over and over in the OBU.

Let me know if this works for you

[koganam]

CalculateOnBarClose is set false in the initialize region of the indicator to force last day display of the indicator.

do you mean I should set it to true ... because if I do I think the indictor will not be displayed on the last currently developing bar, which is what I need?

In which case, all you are really saying is that you want your code block to be run only once per bar, even though you are processing every tick. There is more than one way to do that using a bool flag, but NT actually already provides a ready-made flag called FirstTickOfBar, which is just what it says. Just encase your block and use FirstTickOfBar as a filter.

[B][SIZE=3][COLOR=#000000][FONT=Calibri]if(BarsPeriod.Id == PeriodType.Day)//for day bars [don't use GetDayBar for day bars] [/FONT][/COLOR][/SIZE][/B]
[B][SIZE=3][COLOR=#000000][FONT=Calibri]{[/FONT][/COLOR][/SIZE][/B]
[COLOR=Red][B]if (FirstTickOfBar)
{[/B][/COLOR]
[B][SIZE=3][COLOR=#000000][FONT=Calibri]XXCloseyest=((Open[1]+High[1]+Low[1]+Close[1])*0.25);[/FONT][/COLOR][/SIZE][/B]
[B][SIZE=3][COLOR=#000000][FONT=Calibri]XXOpen=((XXCloseyest+XXOpenyest)*0.5);[/FONT][/COLOR][/SIZE][/B]
[B][SIZE=3][COLOR=#000000][FONT=Calibri]XXOpenyest=XXOpen; //this will be used on next bar, when at that time it will be XXOpenyest[/FONT][/COLOR][/SIZE][/B]
[COLOR=Red][B]}[/B][/COLOR]
[B][SIZE=3][COLOR=#000000][FONT=Calibri]} [/FONT][/COLOR][/SIZE][/B]

[joemiller]

problem solved


"if (FirstTickofBar)" made the problem go away.

As so many times before, much appreciated and many thanks.