DrawLine Help

[PrTester]

I'm trying to Draw a line every time Macd cross 0 , the code is:

protected override void OnBarUpdate()
{

if(MACD(12,26,9)[0] > 0 && MACD(12,26,9)[1] < 0)
{
updotbar=CurrentBar;
updot=High[0];
}

if(MACD(12,26,9)[0] > 0 && MACD(12,26,9)[1] < 0)
{
dndotbar=CurrentBar;
dndot=Low[0];
}

if (updotbar !=0 && updot !=0 && dndotbar!=0 && dndot!=0 )
{
DrawLine("MyLine1"+CurrentBar, updotbar, updot, dndotbar, dndot, Color.Blue);
DrawDiamond("MyDiamond1"+CurrentBar,true,dndotbar, dndot, Color.Red);
DrawDiamond("MyDiamond2"+CurrentBar, true,updotbar, updot, Color.Blue);
}

}

Any Idea of what I'm doing wrong will be appreciated.

Regards

[NinjaTrader_JoshP]

You never reset your updotbar, updot, dndotbar, dndot variables back to zero so after it evaluates to true once it will stay true for your whole chart. Also, your two if statement conditions are exactly the same. I am not sure if that was what you intended. If so you can merge the two together and maybe even share the same variables.