Serializing indicators

[NinjaTrader_Brett]

Thanks,

problem was here:

public DataSeries RangeHigh;

As you found but the reason is the public. This needs to be private as if its Public it gets added to be serialized (Like a property) and since you have no get or set accessor this process fails.

Private will work here if you need to access this DataSeries from external then you need to use this guide:

http://www.ninjatrader.com/support/forum/showthread.php?t=4991

[kenb2004]

OK, thanks Brett, I'll give that a shot.

[koganam]

#region Variables
public DataSeries RangeHigh;

protectedoverridevoid Initialize()
RangeHigh = new DataSeries(this);

protectedoverridevoid OnBarUpdate()
_rangehigh = High[CurrentBar - highBar];
RangeHigh.Set(_rangehigh);

Bret

I uncommented these 3 lines and the serialize error came back. Then I commented them out 1 by 1 starting with the OnBarUpdate and ending with the variable. OnBarUpdate out - error, Initialize out - error, variable out - no error.

I need these DataSeries to DrawRegion, even though I don't understand why you need 1 double and 1 series, or 2 series. Why not 2 doubles?

Thanks

And that is your problem. If you want to access a DataSeries from outside a class, the correct method is to access it by defining public properties to a private data store, not by declaring the DataSeries itself as public.

Here is another thread that discusses that same issue: http://www.ninjatrader.com/support/f...110#post293110

[kenb2004]

So, if public DataSeries RangeHigh;
is changed to private DataSeries RangeHigh;
Then what exactly should the code in properties be to access this DataSeries outside the class?
Thanks

[NinjaTrader_Brett]

The sample on how to do that is here:

http://www.ninjatrader.com/support/forum/showthread.php?t=4991

[kenb2004]

Brett

I see how this works for a BoolSeries and Plots, but how do you change it for a DataSeries?
Thanks

// From SampleBoolSeries
[Browsable(false)]
[XmlIgnore()]
public BoolSeries BullIndication
{
get { return bullIndication; } }

// From SampleCustomDataSeries
[Browsable(false)]
[XmlIgnore()]
public DataSeries AvgR
{
get { return Values[0]; }
}

[NinjaTrader_Brett]

[Browsable(false)]
        [XmlIgnore()]
        public DataSeries BullIndication
        {
            get { return bullIndication; }   
        }

then

private DataSeries bullIndication;

in the variables section with a lowecase b and finally the standard dataseries sync in initialize.

bullIndication            = new DataSeries(this);

[kenb2004]

Thanks Brett

So with a DataSeries there is no reference to Value, like with a plot, int or double?

[NinjaTrader_Brett]

right, since you don't set it in the GUI nor do you want it visible there so you don't want to take a returned value from the GUI to set it.

-Brett

[kenb2004]

Thanks again

[kenb2004]

Is this the proper way to use the current value for the Indicator's DataSeries in a Strategy? Or does it need to stay a DataSeries?

Strategy
protectedoverridevoid OnBarUpdate()
double myDataSeriesValue = SampleCustomDataSeries().MyDataSeries[0];

How would you keep it as a DataSeries and not a double?
MySeries = SampleCustomDataSeries().MyDataSeries[0];

[NinjaTrader_Brett]

Not sure I understand what you ave going on there. No need to set it as a double if you dont want too.

Just access this directly like you do an indicator.

SampleCustomDataSeries().MyDataSeries[0];


Just use that right in the spots you want to access the calculation.

-Brett

[turbofib]

I had the same Serializing problem...

i resolve it like in then example

[Browsable(false)] [XmlIgnore()]
public DataSeries BullIndication
{ get { return bullIndication; } }


then

Code:
private DataSeries bullIndication;

Code:
bullIndication = new DataSeries(this);


When i recall the above indicator ...i set in a strategy the folllowing instruction:


SampleCustomDataSeries().Bullindicator[0];

Is correct?

In your example seem to be following :

SampleCustomDataSeries().bullindicator[0]; >>>>(bullindicator declare in Initialize)

[NinjaTrader_CalH]

Hello Turbofib,

Yes, this is the correct method for getting the data series value that you want

[turbofib]

In the example I posted:

code:
bullIndication private DataSeries;

code:
bullIndication = new DataSeries (this);


bullindication how is it used?

when I use Bullindication