GetTrades()

[ScottB]

Hi,

I am trying to use GetTrades() to get a TradeCollection of trades from a given IOrder (o) Name using the code below in OnPositionUpdate once the trade is flat.

TradeCollection currentTrades = Performance.AllTrades.GetTrades("6E 12-10", o.Name, 1);

I have also tried this using Instrument.FullName instead of the literal. I get 0 entries in my TradeCollection. However, if I use

currentTrades = Performance.AllTrades
foreach(Trade t in currentTrades)
{
if (t.Entry.Name == o.Name)
{
lastProfit = t.ProfitCurrency * t.Quantity;
totalProfit += lastProfit;
Print("ShortTrade P&L " + lastProfit.ToString("##,###.00"));
}
}

I get exactly what I expect. I prefer the GetTrades() approach as this trade list can get quite large by the end of the day.

Can anyone point out what is wrong with my GetTrades() statement?

Thanks in advance.

Scott

[NinjaTrader_JoshP]

Scott,

The GetTrades() approach uses the entry signal's name. A trade is a pair of an entry and an exit. You will need to pass in the name of the entry order and not the exit order for it to find it.

[ScottB]

Josh, thanks for getting back to me so quickly. o.Name is the name of the entry order. Can you think what else the issue might be?

Scott

[NinjaTrader_JoshP]

Scott,

Unfortunately I would not know without seeing complete code and seeing exact output. Were there any errors in Control Center logs?

[ScottB]

No errors but I understand about seeing the code. Rather than go through all that, am I correct in using the signalName from the SubmitOrder method and does my syntax look correct? I am using the unmanaged approach if that matters.

Once those questions are cleared up, I am good to go.

Thanks

[NinjaTrader_JoshP]

Syntax looks fine; you are correct in submitting it as the entry signal name (you could just try typing a string directly like "someSignalName" to see what happens); don't think unmanaged should matter.