Announcement

Collapse
No announcement yet.

Partner 728x90

Collapse

Trading stops

Collapse
X
 
  • Filter
  • Time
  • Show
Clear All
new posts

    Trading stops

    I am brand new at automated trading with Scripts.
    I have a script that executes trades, however after the first order it stops executing trades... what am I missing?

    #2
    Hello,
    I am not sure.

    You can try debugging it:


    Or post the OnBarUpdate() block of your code and we can give you pointers.
    Also, compare your code to the sample strategies to see what the issue may be.
    DenNinjaTrader Customer Service

    Comment


      #3
      Here's my code...

      Code:
       
      if (Input[0] > MACDBB(12, 26, 9).Avg[0] && Above == false)
      {
      Retrace = false;
      Above = true;
      Below = false;
      Print("Cross Above");
      }
      
      // Condition set 2
      if (Input[0] < MACDBB(12, 26, 9).Avg[0] && Below == false)
      {
      Retrace = false;
      Above = false;
      Below = true;
      Print("Cross Below");
      }
      if (FirstTickOfBar && Above == true && LongOrder == false)
      {
      PriorBarRetrace = Round2Tick(((High[1]-Low[1])*.382)+ Low[1])-TickSize;
      Print("Retrace target = " + PriorBarRetrace);
      }
      if (FirstTickOfBar && Below == true && ShortOrder == false)
      {
      PriorBarRetrace = Round2Tick(((High[1]-Low[1])*.618)+ Low[1])+TickSize;
      Print("Retrace target = " + PriorBarRetrace);
      }
      if (Input[0] <= PriorBarRetrace && Above == true && LongOrder == false)
      {
      Retrace = true;
      LongOrder = true;
      ShortOrder = false;
      ExitShort("MACDfollowShort");
      EnterLong("MACDfollowLong");
      Print("ExitShort, EnterLong");
      }
      if (Input[0] >= PriorBarRetrace && Below == true && ShortOrder == false)
      {
      Retrace = true;
      ExitLong("MACDfollowLong");
      LongOrder = false;
      ShortOrder = true;
      EnterShort("MACDfollowShort");
      Print("ExitLong, EnterShort");
      }

      Comment


        #4
        Hello,

        The first thing I see is that this looks like an "always in" strategy, meaing you have an order in the market at all times. When doing this, don't use Exits, just place an order in the opposite direction and it will cancel the order you just had. See the SamleMACrossOver. That should eliminate some of your flags and simplify the code. Try than and see if you can sort out the issue.
        DenNinjaTrader Customer Service

        Comment

        Latest Posts

        Collapse

        Topics Statistics Last Post
        Started by DannyP96, 05-18-2026, 02:38 PM
        1 response
        23 views
        0 likes
        Last Post NinjaTrader_ChelseaB  
        Started by CarlTrading, 05-11-2026, 05:56 AM
        0 responses
        115 views
        0 likes
        Last Post CarlTrading  
        Started by CarlTrading, 05-10-2026, 08:12 PM
        0 responses
        68 views
        0 likes
        Last Post CarlTrading  
        Started by Hwop38, 05-04-2026, 07:02 PM
        0 responses
        222 views
        0 likes
        Last Post Hwop38
        by Hwop38
         
        Started by CaptainJack, 04-24-2026, 11:07 PM
        0 responses
        406 views
        0 likes
        Last Post CaptainJack  
        Working...
        X