alert on Highest High in 7 bars

[rakeshSharma]

when i try this code, it seems to print at every bar instead of the highest bar range in 7
not sure why

// This namespace holds all strategies and is required. Do not change it.
namespace NinjaTrader.Strategy
{
    /// <summary>
    /// Enter the description of your strategy here
    /// </summary>
    [Description("Enter the description of your strategy here")]
    public class HH7Alert : Strategy
    {
        #region Variables
        // Wizard generated variables
          private int period1 = 7; // Default setting for Period
            private int barcounter = 0;
            
        // User defined variables (add any user defined variables below)
        private WinTrace myWinTrace ;
        #endregion

        /// <summary>
        /// This method is used to configure the strategy and is called once before any strategy method is called.
        /// </summary>
        protected override void Initialize()
        {
            CalculateOnBarClose = true;
            
                myWinTrace = new WinTrace ("MyWINID", "My trace window");
        }

        /// <summary>
        /// Called on each bar update event (incoming tick)
        /// </summary>
        /// 
        
        
        protected override void OnBarUpdate()
        {
               // Do not calculate if we don't have enough bars 
            if (CurrentBar < period1) return;
             if (FirstTickOfBar)
                barcounter++;
            // Get a sum of prices over the specified period 
            double sum = 0; 
            
            int hh7bar = 0;
    
            // loop for HH7
            for (int barsAgo = 0; barsAgo < period1; barsAgo++) 
            { 
                if ( Range()[barsAgo] >= Range()[0] )
                {
                    hh7bar = barsAgo;
                }
            }
            

            
            // HH7  plotting
            if (hh7bar==0)
            {
                //DrawDot("HH7"+barcounter.ToString(), true, 0, Low[0] - (4*TickSize), Color.DarkRed);
                //BackColor = nr7color;
                //send alert to me
                
                
                
                Print("HH7" + Instrument.FullName,        "HH7" + hh7bar.ToString());
            }
            
            
        }

 
    }

[NinjaTrader_Bertrand]

Hi rakeshSharma, welcome to our support forums! Not sure I follow - are you looking for the highest high over the last 7 bars or the highest bar range over the last 7 bars? For both it may be easier to work directly with the MAX method - http://www.ninjatrader-support.com/H...aximumMAX.html

[rakeshSharma]

i am trying to check if the current bar range > max range in last 7 bars. if so, i want to print it.

[NinjaTrader_JoshP]

If you want the max range you should just use MAX(Range, 7)[0].

if (Range()[0] >= MAX(Range, 7)[0])

Note that MAX(Range, 7)[0] is inclusive of Range()[0]. If you actually want the 7 prior bars you need to change it to MAX(Range, 7)[1].

[rakeshSharma]

hmmm. i modified the code but the print is not alerting that i have hh7. pl let me know if i am doing something wrong.

 protected override void OnBarUpdate()
        {
               // Do not calculate if we don't have enough bars 
            if (CurrentBar < period1) return;
             
            myWinTrace.Debug.Send("outside checking" );
            
            // HH7  plotting
            if (Range()[0] >= MAX(Range(), 7)[1])
            {
                
                myWinTrace.Debug.Send("inside checking" );
            
                //DrawDot("HH7"+barcounter.ToString(), true, 0, Low[0] - (4*TickSize), Color.DarkRed);
                //BackColor = nr7color;
                //send alert to me
                
                //myWinTrace.Debug.Send ("HH7" + Instrument.FullName +        "HH7"  +  "max range so far " +  MAX(Range(), 7)[1] + "current range " +Range()[0]  );
                Print("HH7" + Instrument.FullName +        "HH7"  +  "max range so far " +  MAX(Range(), 7)[1] + "current range " +Range()[0]  );
            }
            
            
        }

[NinjaTrader_JoshP]

Check your Control Center for errors. Do you see any?

[rakeshSharma]

no errors in my control panel

[NinjaTrader_JoshP]

What behavior are you seeing currently then? What are your print outputs printing?

[rakeshSharma]

i am running my strategy on NQ -06-09 with IB on 1 minute bars. i can definitely see HH7 bars flying regularly. but there is nothing on my output window. definitely strange and thats why i am stuck.

[NinjaTrader_JoshP]

Print these components individually:
if (Range()[0] >= MAX(Range(), 7)[1])

So you can evaluate the if-statement.

[rakeshSharma]

i was using the strategy on control center. i had added the strategy and hit the start button to run it. when i made changes to the strategy. i compiled and stopeed and restarted the stratgegy. it did not take effect unless i delete the strategy from the strategies tab and readded them.

[NinjaTrader_JoshP]

That is correct. You need to load a new instance of the strategy.

[rakeshSharma]

if i close NT and restart it, would it automatically get the newer code that was compiled or do i have to remove and add again?

[NinjaTrader_JoshP]

If you close NT it will already be removed so you would be loading a new version anyways.