BarrsInProgress == 1 not being activated

[stearno]

I converted this from NT7. I did AddDataSeries in the State.Change.

I have put Print("Here") in the State.Change and it shows in the Output window. But I have the Print("here2") in the BarsInProgress == 1, and it does not show in the output window.

In my code, I need BarsInProgress == 1 occurs before BarsInProgress == 0. I dont know if that makes a difference.

I have checked the Help Guide, but I cannot figure out why the bars in progress one is not being activated.

I appreciate your advice. Thanks.

-Stearno

[NinjaTrader_PatrickH]

Hello stearno,

Thank you for your post.

Are there any errors listed in the Log tab of the Control Center when adding the indicator or strategy?

[stearno]

error log

Nope, there are no errors related to indicators (screenshot attached).

[NinjaTrader_PatrickH]

stearno,

May I test the full code? If so, could you attach it to your response in it's .cs file format from Documents\NinjaTrader 8\bin\Custom\Indicator or Strategy?

[sledge]

You add a day bar series, but issue a return after seeing it?

[stearno]

Patrick,
Here is the full code.

[NinjaTrader_PatrickH]

sledge pointed out the item here. You are returning the OnBarUpdate() method in lines 93 to 96 in your code:

				else
				{
					if (Bars.BarsPeriod.BarsPeriodType == BarsPeriodType.Day) return;
				}

Nothing gets processed passed this point if it is a daily bar.

[stearno]

sledge pointed out the item here. You are returning the OnBarUpdate() method in lines 93 to 96 in your code:

				else
				{
					if (Bars.BarsPeriod.BarsPeriodType == BarsPeriodType.Day) return;
				}

Nothing gets processed passed this point if it is a daily bar.

The idea behind that is the indicator will give errors from calcs if on a day chart. So this returns after doing nothing if the chart is a daily chart. Since the chart is a minute chart, this is fine.

Plus, as I showed with print command, It makes it to right before the bars in progress =1, also it reaches to right after that section. Finally, it makes it just fine to inside the bars in progress =2 section. All of this even with this return.

So it is not that.

-Stearno

[sledge]

in your 1st post: "But I have the Print("here2") in the BarsInProgress == 1, and it does not show in the output window."


I do not see "here2" at all in my output window.
All I see is "here".

I am using Playback-Market Replay on ES 06-14.

I used 1 minute, 2 minutes, and daily chart.

The dailychart only prints the very first "here". Nothing else.

So, yes it is the problem.

[stearno]

in your 1st post: "But I have the Print("here2") in the BarsInProgress == 1, and it does not show in the output window."


I do not see "here2" at all in my output window.
All I see is "here".

I am using Playback-Market Replay on ES 06-14.

I used 1 minute, 2 minutes, and daily chart.

The dailychart only prints the very first "here". Nothing else.

So, yes it is the problem.

I don't mean to argue, but that does not even make sense.

The code says:

 if (Bars.BarsPeriod.BarsPeriodType == BarsPeriodType.Minute)
				{		
					
				}
				else
				{
					//if (Bars.BarsPeriod.BarsPeriodType == BarsPeriodType.Day) return;
				}

then it has

BarsInProgress == 1 
{ 
Print("here2")
}

then it has

BarsInProgress == 2 
{
 Print("here")
}

The print "here" shows in the output window and the print here2 does not. How is it possible that a return above all of this is the cause of one section to work but the section to not work.

Anyway, I removed the line you are referring to and it still only shows "here" and not "here2". It still does not work even with that code removed. So if I am not understanding something, please explain as I am always looking to improve my coding.

I still think there is something else wrong with the code that BarsInProgress == 1 is not being activated. It works just fine as it is written in NT7 as it is wrttien. So most likely, I think, it has something to do with initiating a another data series. NT8 is doing something different, so and it is probably something small.

I appreciate anyone help and guidance.

-Stearno

[sledge]

That code is different than what you posted. That line was not commented out at all.

I would expect here2 to print in this case.

[stearno]

Yes it is different because as I said, I removed it and it still does same thing. This proves this is jot the problem because as you can see it was removed.

So since that is not it could you please look over the code again and see with fresh eyes what the problem is?

Or support, I would appreciate your perspective on this problem as well Sledge's.

[sledge]

I'll look tonight and comment out the line and see where it goes.

[NinjaTrader_PatrickH]

Hello stearno,

Thank you for your response.

Provide the full code as it should be tested so we may investigate on our end.

[sledge]

How many days do you have to load for this? It looks like 24 days is necessary for a 60 minute chart and 1,440 days for a 1 minute chart.

You'll see by changing your code to this, and why you aren't getting to here2 anytime soon.

			if (Bars.BarsPeriod.BarsPeriodType == BarsPeriodType.Minute)
				{		
					BarsRequired 		= 	(1440/Bars.BarsPeriod.Value);	//for 60 min chart = 24
					barsinaperiod		=	(1440/Bars.BarsPeriod.Value)-1;	//for 60 min chart = 23
					LineBegininBars		=	(1440/Bars.BarsPeriod.Value)-1;	//for 2 min chart = 23
					barsPivotValidFor	=	((1440/Bars.BarsPeriod.Value)*(pivotValidFor-1));
					
					Print ( "CurrentBar=" + CurrentBar + " BarsRequired=" + BarsRequired );
				}
				else
				{
					Print ( "**** CurrentBar=" + CurrentBar + " BarsRequired=" + BarsRequired );//if (Bars.BarsPeriod.BarsPeriodType == BarsPeriodType.Day) return;
				}
							
		if (CurrentBar <= BarsRequired) return;
					 
		if (BarsInProgress == 1)
			{  Print("here2");