Counting Renko up and down bars

[arbuthnot]

Hi everyone

I'm simply trying to count the number of Renko ups and downs over a given period and get a ratio. Getting a weird problem with the plot even though it compiles OK. This is the code:

if (CurrentBar < LookBack)
        		return;
		
int CountUp = CountIf(delegate {return Close[0] > Open[0];}, LookBack);
int CountDown = CountIf(delegate {return Close[0] < Open[0];}, LookBack);
			
double a = CountUp / (CountUp + CountDown);

            Plot0.Set( (double) a);

With Plot0.Set( (CountUp) there's no problem, but:

- Plot0.Set(a) plots to zero only

- Plot0.Set( (double) a) it sometimes plots to zero and sometimes plots as the expected decimal.

There are no errors in the log.

Could someone please explain the best way to approach this.

Many thanks in advance.

[NinjaTrader_Jesse]

Hello,

This is because of the math you are doing.

You are dividing a double number against a integer which will result in a 0.


Here is a simple breakdown:

                     Double  / int (Int+Int)
double a = CountUp / (CountUp + CountDown);

you would need to cast your int result as a double before dividing like so:

double a = CountUp / (double)(CountUp + CountDown);
Plot0.Set(a);

Please let me know if I may be of additional assistance.

[arbuthnot]

Thanks as always, Jesse, for the solution with a great explanation.