Using Swing indicator

[2Look4me]

ChelseaB, Thanks for the help and clarification. Seems to be working.

[2Look4me]

Hi,

If I have indicator "ABC" with the code that Patrick provided and want a new indicator "XYZ" to call on the values of "ABC" , will the following be the proper way to do this?... since it's not exactly working out for me.

OnBarUpdate()

double SwingH  =  (Swing(5).SwingHigh[CurrentBar - highBarNum]);
double SwingL  =   (Swing(5).SwingLow[CurrentBar - lowBarNum]);

Thanks in advance .

[NinjaTrader_ChelseaB]

Hello 2Look4me,

I'm not quite sure what you are asking.

However, if you have indicator ABC and want to call XYZ, this would work the same as any indicator call.


double myValue = XYZ()[0];

Patrick is demonstrating that you can call the swing from another indicator.

if (Swing(5).SwingHigh[0] > Swing(5).SwingHigh[6])

This checks that the current swing high is greater than the swing high of 6 bars ago.


If you are getting an error, what is the error?

[2Look4me]

Hi ChelseaB,

Thanks for the reply. I'm having the following issues; in using the same code and just changing CalculateOnBarClose from True to False or vice versa, it will plot different results (attachments). Once the chart is refreshed the problem is gone and the plots match.

I used the one minute time frame, but I'm having the same issues with other time frames also.

#region Variables
        private int switchSwing = 0;
        private int highBarNum = 0;
        private int lowBarNum = 0;
        #endregion

        /// <summary>
        /// This method is used to configure the indicator and is called once before any bar data is loaded.
        /// </summary>
        protected override void Initialize()
        {
            MaximumBarsLookBack = MaximumBarsLookBack.Infinite;
            CalculateOnBarClose    = false;
            Overlay = true;
            AutoScale = false;
            DrawOnPricePanel = true;
        }

        /// <summary>
        /// Called on each bar update event (incoming tick)
        /// </summary>
        protected override void OnBarUpdate()
        {
            if(CurrentBar <6)
                return;
            if(CurrentBar == 0)
            {
                highBarNum = CurrentBar;
                lowBarNum = CurrentBar;
            }
            
            if(Swing(5).SwingHigh[0] > Swing(5).SwingHigh[6]
                && Swing(5).SwingLow[0] == Swing(5).SwingLow[6])
            {
                highBarNum = CurrentBar;
            }
            if(Swing(5).SwingLow[0] < Swing(5).SwingLow[6]
                && Swing(5).SwingHigh[0] == Swing(5).SwingHigh[6])
            {
                lowBarNum = CurrentBar;
            }
            
                DrawLine("l"+lowBarNum, true, CurrentBar - lowBarNum, Swing(5).SwingLow[CurrentBar - lowBarNum], 0, Swing(5).SwingLow[CurrentBar - lowBarNum], Color.Black, DashStyle.Solid,4);
                DrawLine("h"+highBarNum, true, CurrentBar - highBarNum, Swing(5).SwingHigh[CurrentBar - highBarNum], 0, Swing(5).SwingHigh[CurrentBar - highBarNum], Color.Black, DashStyle.Solid,4);
        }

[NinjaTrader_ChelseaB]

Hello 2Look4me,

When Calculate on bar close is set to True, this means that the script processes once per bar after the bar closes and the bar is complete.

When Calculate on bar close is set to False, this means that the script processes on every tick before the bar closes and before the bar is complete.

This means that you are providing half a bar's information to an indicator and comparing this to the full bars information.

Why are you expecting this to be the same?

I would expect the historical to be the same after this is reloaded, but I would not expect this to be the same when running live.

In your screenshot, is this historical or live data?

[2Look4me]

I appreciate your explanation as it is very helpful.

The ABC indicator calls on the values:
Swing(5).SwingHigh[CurrentBar - highBarNum] and
Swing(5).SwingLow[CurrentBar - lowBarNum]; but I keep getting a Print =0.
Where am I going wrong?

[NinjaTrader_ChelseaB]

Hello 2Look4me,

May I have an exported example?

(A short example with only that print in it and no other code)

To export your script do the following:

1. Click File -> Utilities -> Export NinjaScript
2. Enter a unique name for the file in the value for 'File name:'
3. Select the strategy from the objects list on the left -> click the right facing arrow ">" to add the strategy to the export
4. Click the 'Export' button -> click 'yes' to add any referenced indicators to the export -> click OK to clear the export location message

By default your exported file will be in the following location:

• (My) Documents/NinjaTrader 7/bin/Custom/ExportNinjaScript/<export_file_name.zip>

Below is a link to the help guide on Exporting NinjaScripts.
http://www.ninjatrader.com/support/h...nt7/export.htm

[2Look4me]

Chelsea, thanks again.
I'm attaching the script with the changes, but as I call the values from another indicator,

double SwingH  = (aaaTestingSwingHL(5).SwingHighest[0]);
double SwingL  = (aaaTestingSwingHL(5).SwingLowest[0]);

there's a compile error "is inaccessible due to its protection level". I cannot get it to pass on the SwingHighest and SwingLowest values.

[NinjaTrader_DaveI]

Hello,

That should be easily fixed. It looks like SwingHighest and SwingLowest currently only exist as private doubles in this script. In order to access them outside of the script, you will need to define public properties, the way you have done for SwingHigh and SwingLow. Note that these will be public double properties, rather than public DataSeries.

Please give that a shot and see if the error is resolved.

[2Look4me]

Thanks for the suggestions. As I define them in the properties section

[Browsable(false)]
        [XmlIgnore()]
        public double SwingHighest
        {
            get 
            { 
                Update();
                return swingHighest; 
            }
        }
        [Browsable(false)]
        [XmlIgnore()]
        public double SwingLowest
        {
            get 
            { 
                Update();
                return swingLowest; 
            }
        }

I then get a compile error:
NinjaTrader indicator....already contains a definition for SwingHighest
NinjaTrader indicator....already contains a definition for SwingLowest

[NinjaTrader_DaveI]

Hello,

If I remember correctly, didn't your private variables also begin with capital letters? If so, you will now have private variables and public properties with the exact same name. As a good best practice, I recommend beginning your private variables with lowercase letters, and beginning your properties with capital letters.

Let me know if I'm remembering incorrectly, and I'll take a closer look.

[2Look4me]

Dave, you are correct about the private variables being in capital letters. I made the changes and also changed the private variable to a public variable

#region Variables
public double  SwingHighest = 0;
#endregion

#region properties
[Browsable (false)]
[XmlIgnore()]
public double swingHighest  {
get 
{ update();
return SwingHighest; 
}
}

as I call SwingHighest from another indicator

double SwingH  = (aaaTestingSwingHL(5).SwingHighest[0]);

there's a compile error: "Cannot apply indexing with [] to an expression of type double"

Thanks again for your patience.

[NinjaTrader_Jesse]

Hello,

If you are trying to access a double value from another indicator, you can not apply a BarsAgo as you have in your example like it is a dataseries.

This would have an issue compiling:

double SwingH  = (aaaTestingSwingHL(5).SwingHighest[0]);

Because that is the same as saying:

double SwingHighest = 0; 

Print(SwingHighest[0]);

The [0] would be invalid because that is just a double and not a dataSeries, I believe what you are actually trying to use is a DataSeries.

An example would be accessing the SMA or SMA(12)[0]

In your case, you would need to change the double

private double		SwingHighest	= 0;
private double		SwingLowest	= 0;

to

private DataSeries		SwingHighest;
private DataSeries		SwingLowest;

And create the dataseries in Initialize as you have with the others in your script.

The public property would then look like the following:

[Browsable(false)]
[XmlIgnore()]
public DataSeries SwingHighestSeries
{
	get 
	{ 
		return Values[5]; // this index is according to the order you have your SwingHighest = new DataSeries(this)
	}
}
[Browsable(false)]
[XmlIgnore()]
public DataSeries SwingLowestSeries
{
	get 
	{ 
		return Values[6];
	}
}

Finally anywhere in the indicator where you have the SwingHighest or Lowest data series, instead of assiging a value you would use

SwingHighest.Set(value);

and anywhere you use the variable SwingHighest in the indicator, you would replace with SwingHighest[0]

Please let me know if I may be of additional assistance.

[2Look4me]

Hi Jesse,

Thanks for explaining the issues in detail. I made the suggested changes except for those in the 'Properties" region, which I have as:

public DataSeries SwingHighest
              {
                    get 
                    { 
                          Update();
                          return swingHighestSeries; 
                    }
              }

It all worked as I printed SwingHighest and SwingLowest in the XYZ indicator and indicator ABC as it called on those values.

The issue is that XYZ will print those values once calculated, but there's a 3-5 minutes lag before ABC will print/access those same values in the XYZ indicator.

[NinjaTrader_MichaelM]

Hello 2Look4Me,

When you say 3-5 minutes lag do you mean when you run your ABC and XYZ indicators at the same time, once the XYZ indicator prints a value, the ABC indicator doesn't print that same value for 3-5 minutes afterwards?

Could you please provide a brief example of the code you are using to print in both indicators?

Thank you in advance for clarifying.