Accumulate the value of an indicator

[ManIp]

Hi,

I'm not a programmer therefore I was stucked in develop a new indicator
I would like to develop the indicator with accumulate the value if some criteria is fullfiled:

Example:

// condition 1
if (SMA(Close, fastMA)[0] > SMA(Close, slowMA)[0]
{Ratio.Set(macs + 1);};

// condition 2
if (SMA(Close, fastMA*2)[0] > SMA(Close, slowMA*2)[0])
{Ratio.Set(macs + 1);};

In the above condition 1 & 2, my ideal result of "macs" should be "2" if condition 1 & 2 fulfilled at the same period. However, the result was "1".

I understood I was missing some code in order to accumulate the value of "macs". Can anyone help? Thanks a lot!

[koganam]

Hi,

I'm not a programmer therefore I was stucked in develop a new indicator
I would like to develop the indicator with accumulate the value if some criteria is fullfiled:

Example:

// condition 1
if (SMA(Close, fastMA)[0] > SMA(Close, slowMA)[0]
{Ratio.Set(macs + 1);};

// condition 2
if (SMA(Close, fastMA*2)[0] > SMA(Close, slowMA*2)[0])
{Ratio.Set(macs + 1);};

In the above condition 1 & 2, my ideal result of "macs" should be "2" if condition 1 & 2 fulfilled at the same period. However, the result was "1".

I understood I was missing some code in order to accumulate the value of "macs". Can anyone help? Thanks a lot!

You have to accumulate somewhere. What you have done here is take a quantity and use it after adjusting it, but without ever storing the adjustment. You can either first store the value that you want to use, then use it, or you can accumulate in situ. In situ accumulation while performing another operation is generally frowned upon as bad practice because ultimately it encourages coding that can produce unintended side effects.

//Accumulate, then assign:
//*****************************
// condition 1                                    
if (SMA(Close, fastMA)[0] > SMA(Close, slowMA)[0]
{macs = macs + 1; //or macs += 1;
Ratio.Set(macs);}

// condition 2                        
if (SMA(Close, fastMA*2)[0] > SMA(Close, slowMA*2)[0])
{macs = macs + 1; //or macs += 1;
Ratio.Set(macs);}

//Accumulate in situ:
//**********************
// condition 1                                    
if (SMA(Close, fastMA)[0] > SMA(Close, slowMA)[0]
{Ratio.Set(++macs);}

// condition 2                        
if (SMA(Close, fastMA*2)[0] > SMA(Close, slowMA*2)[0])
{Ratio.Set(++macs);}

[NinjaTrader_PatrickH]

Hello ManIp,

Thank you for your post.

Koganam is correct, the value is never stored thus the value is 1 as macs is likely 0 to start. So using a variable we can first store the additions based on the conditions and then set this as the DataSeries value.

[ManIp]

THANKS VERY MUCH Koganam! I got what I want and I can further develop this indicator!