Multi-timeframe Indicator

[happypappy]

Hey guys can't seem to get this to work, I know its something stupid....Works fine if I take the time frames away. I've tried TH.Set(BarsArray[1].GetClose(0)); high low etc in it's place still no luck....





public class TDT : Indicator
{
#region Variables
// Wizard generated variables
public int t1 = 1; // Default setting for T1
public int t2 = 1; // Default setting for T2
public int t3 = 1; // Default setting for T3
public int t4 = 1; // Default setting for T4

// User defined variables (add any user defined variables below)
#endregion

/// <summary>
/// This method is used to configure the indicator and is called once before any bar data is loaded.
/// </summary>
protected override void Initialize()
{
Add(PeriodType.Minute, t1); // ON CHART
Add(PeriodType.Minute, t2); // ON CHART
Add(PeriodType.Minute, t3); // ON CHART
Add(PeriodType.Minute, t4); // USED TO CALC TIME DILATION
Add(new Plot(Color.FromKnownColor(KnownColor.SeaGreen), PlotStyle.Line, "TD"));
Overlay = false;
}

/// <summary>
/// Called on each bar update event (incoming tick)
/// </summary>
protected override void OnBarUpdate()
{
#region TDT
TH.Set(Close[0]);
TL.Set(High[0]);
TD.Set(Low[0]);
#endregion

}

[happypappy]

I just cant seem to get the indicator to plot if I have more then 1 time frame, take the time frames away it's fine. Not sure if its the variables Im passing from the properties or just not working.

[NinjaTrader_CalH]

Happyhappy,

Thank you for your post.

Do you receive any errors in the Log Tab of the Control Center after adding the indicator to the chart?

[happypappy]

Error on calling 'OnBarUpdate' method for indicator 'TDT' on bar 0: You are accessing an index with a value that is invalid since its out of range. I.E. accessing a series [barsAgo] with a value of 5 when there are only 4 bars on the chart.

Seems to occur when I have more then 1 time frame. I've resolved with a try{CODE}catch{}. This error appears in output, can i suggest for the new version that it pop up when creating on adding a new indicator.

[happypappy]

TH.Set(Close[0]);
TL.Set(High[0]);
TD.Set(Low[0]);

Also I can't use 0 it is a flat value for some reason I think its the first bar in the series. I had to use CurrentBar.

[NinjaTrader_CalH]

Happyhappy,

You will need to use a CurrentBars check for all the timeframes you are adding.

if(CurrentBars[0] < 1 || CurrentBars[1] < 1 || ...etc...)
return;

[koganam]

Hey guys can't seem to get this to work, I know its something stupid....Works fine if I take the time frames away. I've tried TH.Set(BarsArray[1].GetClose(0)); high low etc in it's place still no luck....





public class TDT : Indicator
{
#region Variables
// Wizard generated variables
public int t1 = 1; // Default setting for T1
public int t2 = 1; // Default setting for T2
public int t3 = 1; // Default setting for T3
public int t4 = 1; // Default setting for T4

// User defined variables (add any user defined variables below)
#endregion

/// <summary>
/// This method is used to configure the indicator and is called once before any bar data is loaded.
/// </summary>
protected override void Initialize()
{
Add(PeriodType.Minute, t1); // ON CHART
Add(PeriodType.Minute, t2); // ON CHART
Add(PeriodType.Minute, t3); // ON CHART
Add(PeriodType.Minute, t4); // USED TO CALC TIME DILATION
Add(new Plot(Color.FromKnownColor(KnownColor.SeaGreen), PlotStyle.Line, "TD"));
Overlay = false;
}

/// <summary>
/// Called on each bar update event (incoming tick)
/// </summary>
protected override void OnBarUpdate()
{
#region TDT
TH.Set(Close[0]);
TL.Set(High[0]);
TD.Set(Low[0]);
#endregion

}

I do not see any declarations for TH or TL. What are they supposed to be?

[happypappy]

Happyhappy,

You will need to use a CurrentBars check for all the timeframes you are adding.

if(CurrentBars[0] < 1 || CurrentBars[1] < 1 || ...etc...)
return;

NinjaTrader_Cal,

Thank you this resolved my issue.