Help with Indicator Development

[sandeshrai]

Unprotected code

Sorry, please find attached un protected file

[NinjaTrader_PatrickH]

Hello sandeshrai,

Thank you for your response.

Please remove the following lines from the Initilize() method and place them in the OnBarUpdate() method at the beginning:

protected override void OnBarUpdate()
        {
			if (CurrentBar < 200)
        return;
			
			indSMAFast = SMA(this.iSMAFast);
			indSMAFast.Plots[0].Pen.Color = Color.Purple;
			
			indSMAMedium = SMA(this.iSMAMedium);
			indSMAMedium.Plots[0].Pen.Color = Color.DarkBlue;
			
			indSMASlow = SMA(this.iSMASlow);
			indSMASlow.Plots[0].Pen.Color = Color.ForestGreen;
			
			indSMAVSlow = SMA(this.iSMAVSlow);
			indSMAVSlow.Plots[0].Pen.Color = Color.Red;

Please let me know if I may be of further assistance.

[koganam]

Hi Patrick,

I added the Print statements, but that doesn ot print either. Additionally, I tried to have the SMA to be visible on the chart by adding the line :Add (indSMAFast);. I get the error messages

The best overloaded method match for 'NinjaTrader.Indicator.IndicatorBase.Add(NinjaTrad er.Gui.Chart.Line)' has some invalid arguments

and

Argument '1': cannot convert from 'NinjaTrader.Indicator.SMA' to 'NinjaTrader.Gui.Chart.Line'

I have attached a text file with the entire code

Your conditions are never being met, because you have only created your SMA's wiithout ever synchronizing them to any object or barSeries.

Move the code that you use to assign the named instances of SMA to their objects into OnStartUp().

[sandeshrai]

Updated code as per your suggestion

I updated the code as suggested by you. It still does not do what it is supposed to do.

Hello sandeshrai,

Thank you for your response.

Please remove the following lines from the Initilize() method and place them in the OnBarUpdate() method at the beginning:

protected override void OnBarUpdate()
        {
            if (CurrentBar < 200)
        return;
 
            indSMAFast = SMA(this.iSMAFast);
            indSMAFast.Plots[0].Pen.Color = Color.Purple;
 
            indSMAMedium = SMA(this.iSMAMedium);
            indSMAMedium.Plots[0].Pen.Color = Color.DarkBlue;
 
            indSMASlow = SMA(this.iSMASlow);
            indSMASlow.Plots[0].Pen.Color = Color.ForestGreen;
 
            indSMAVSlow = SMA(this.iSMAVSlow);
            indSMAVSlow.Plots[0].Pen.Color = Color.Red;

Please let me know if I may be of further assistance.

[koganam]

I updated the code as suggested by you. It still does not do what it is supposed to do.

That cannot possibly work. You are instantiating the named instances of the indicators on every tick, so they are always in a virgin state.

[NinjaTrader_PatrickH]

Hello sandeshrai,

Thank you for your response.

The indicator is working on my end, please forward me once again the indicator code you are now using after the updates.

I look forward to your response.

[sandeshrai]

Updated code attached

Here is the updated code attached

[NinjaTrader_PatrickH]

Hello sandeshrai,

Thank you for your response.

Please try the attached file on your end and advise if it works properly.

[sandeshrai]

It works now. Thank you very much for your help