code question in @swing.cs

[e-man]

greetings - shouldn't line 236 match 273? if not, why not?

236                if (instance == 1) // 1-based, < to be save
...
273                if (instance <= 1) // 1-based, < to be save

NT 7.0.1000.10

cheers,
-e

[NinjaTrader_Joydeep]

Hello e-man,
Thanks for your post.

While I am not exactly sure why it is coded like this, are you witnessing anything unexpected. If so please let me know your findings.

I will however test it further at my end.

[e-man]

just noticed a possible discrepancy in the code and was curious to know if that was intentional or an oversight.

cheers,
-e

[NinjaTrader_Joydeep]

Hello e-man,
Thanks for your note.

I will test it further and will let you know my findings. Thanks for your patience.

[NinjaTrader_Joydeep]

Hello e-man,
The functionality of the code remains the same and I cannot find any difference while testing it under different scenario's. Are you running into issue with this code?

We would not have our original notes handy as to why it is how it is.

If you find a bug with the output we would want to look into it immediately.

[e-man]

i am not using that exact indicator, so i haven't been testing whether it works or not.

i noticed a discrepancy and was curious to know if it was an oversight or if it was intentional (and if intentional, then what the reasoning was).

perhaps engineering could review and comment when time permits.

cheers,
-e

[NinjaTrader_Joydeep]

Hello e-man,
Thanks for your post.

I will let development know to further review the code.