SMA indicator code

[dpicon]

Hi,

I might be very thick this morning, but looking at the SMA indicator code I found that both Math.Min calls are unnecessary.

protected override void OnBarUpdate()
		{
			Print("OBU currentbar: "+CurrentBar);
			if (CurrentBar == 0)
				Value.Set(Input[0]);
			else
			{
				double last = Value[1] * Math.Min(CurrentBar, Period);

				if (CurrentBar >= Period)
					Value.Set((last + Input[0] - Input[Period]) / Math.Min(CurrentBar, Period));
				else
					Value.Set((last + Input[0]) / (Math.Min(CurrentBar, Period) + 1));
			}
		}

Could be:

protected override void OnBarUpdate()
		{
			Print("OBU currentbar: "+CurrentBar);
			if (CurrentBar == 0)
				Value.Set(Input[0]);
			else
			{
				double last = Value[1] * Math.Min(CurrentBar, Period);

				if (CurrentBar >= Period)
					Value.Set((last + Input[0] - Input[Period]) / Period);
				else
					Value.Set((last + Input[0]) / (CurrentBar + 1));
			}
		}

Am I missing something or we could do this simple optimization?

PS.- I'm not trying to be critical, I ask this because I need to modify the SMA indicator and this got me confused...

[NinjaTrader_Bertrand]

I think you're correct dpicon, shouldn't be needed - we're are looking into further optimizing our system indicators further as well in the future to provide highest efficiency.

[dpicon]

I think you're correct dpicon, shouldn't be needed - we're are looking into further optimizing our system indicators further as well in the future to provide highest efficiency.

Actually you could optimize it further by removing too the Math.Min from the "last" variable and calculating "last" into both if cases.

As SMAs are being used by many many traders we could save a few ticks(*) per trader, and therefore reduce the carbon footprint of the trader community...


(*) CPU ticks...