Announcement

Collapse
No announcement yet.

Partner 728x90

Collapse

Find Double Tops from the current bar

Collapse
X
 
  • Filter
  • Time
  • Show
Clear All
new posts

    Find Double Tops from the current bar

    Hi,

    I took parts from the Ninja PA indicator and rewrote them to find DTs/DBs. The original finds them only in hindsight (after the completion of the most recent swing) and not all of them (only one swing back).

    The code below is supposed to find all of them.
    Does anybody have an idea, why this is not working?
    It should test for DTs from the current bar (working bar) and draw text above that bar.

    It should work for live and historical data.

    These are my first steps with NT script. I´m coming from MQL and wrote several indicators including PA indis.

    if (CurrentBar < 70) return;

    double offset = 0.25;
    double toffset = 0.50;

    double curhigh = High[CurrentBar];
    for (int i = 1; i < 70; i++)
    {
    double prevhigh = 0;
    int barsback2 = Swing(1).SwingHighBar(2,i,70);
    if (barsback2 == -1) break;
    prevhigh = Swing(1).SwingHigh[barsback2];
    if (prevhigh > curhigh + offset) break;
    if (curhigh <= prevhigh + offset && curhigh >= prevhigh - offset)
    {
    DrawText("DT"+CurrentBar,"DT",0, High[CurrentBar] + toffset, Color.Peru);
    break;
    }
    }
    Last edited by td_910; 12-17-2011, 05:28 AM.

    #2
    works now

    mixed up CurrentBar with the relative addressing from the "other end"

    see below

    private double curhigh, prevhigh;
    private int barsback;

    curhigh = High[0];

    for (int i = 1; i < 70; i++)
    {
    prevhigh = 0;
    barsback = Swing(1).SwingHighBar(0,i,70);
    if (barsback < 2) break;
    prevhigh = Swing(1).SwingHigh[barsback];
    if (prevhigh > curhigh + offset) break;
    if (curhigh <= prevhigh + offset && curhigh >= prevhigh - offset)
    {
    DrawText("DT"+CurrentBar,"DT",0, High[0] + toffset, Color.Peru);
    break;
    }
    }

    Comment


      #3
      td_910

      I am happy you have resolved your issue.

      Please don't hesitate to contact us should you require additional assistance.
      Adam P.NinjaTrader Customer Service

      Comment

      Latest Posts

      Collapse

      Topics Statistics Last Post
      Started by SalmaTrader, 07-07-2026, 10:26 PM
      0 responses
      26 views
      0 likes
      Last Post SalmaTrader  
      Started by CarlTrading, 07-05-2026, 01:16 PM
      0 responses
      15 views
      0 likes
      Last Post CarlTrading  
      Started by CaptainJack, 06-17-2026, 10:32 AM
      0 responses
      9 views
      0 likes
      Last Post CaptainJack  
      Started by kinfxhk, 06-17-2026, 04:15 AM
      0 responses
      10 views
      0 likes
      Last Post kinfxhk
      by kinfxhk
       
      Started by kinfxhk, 06-17-2026, 04:06 AM
      0 responses
      17 views
      0 likes
      Last Post kinfxhk
      by kinfxhk
       
      Working...
      X