Calculation of AO values

[jed77]

I have some problem calculating the value of the AO indicator.

As variables, I have :

// AOMinusOne is the previous AO bar. AOMinusTwo is 2 bars before
        
        bool AOMinusOne;
        bool AOMinusTwo;

Calculation is at bar close. I think my problem is in this part :

  protected override void OnBarUpdate()
        {
            
        //    Calculation of AOMinusOne
        // If AOMinusOne is red, AOMinusOne is false, else, is true
            if (FirstTickOfBar) {
                
                if ((AO()[Math.Min(CurrentBar, 1)] < AO()[Math.Min(CurrentBar, 2)]))
                    AOMinusOne = true;
                else 
                    AOMinusOne = false;
.......

I want to draw a pink diamond when :

        if ((AOMinusOne== false));
            {
                DrawDiamond("My diamond" + CurrentBar, false, 0, High[0], Color.LightCoral);
            }

The problem is that the diamond is drawn at the high of each bar, not only when the previous AO bar is red....
I think, my problem is in the definition of the previous AO bar : AO()[Math.Min(CurrentBar, 1)

Any ideas ?

Thank you very much for your help !
Jed

[NinjaTrader_JoshP]

You would probably want to use AO().AOValue[int barsAgo] if you are using my 3rd party release. http://www.ninjatrader-support2.com/...ome+oscillator

[jed77]

Like this ?

if ((AO().AOValue[1 barsAgo] < AO().AOValue[2 barsAgo]))
                    AOMinusOne = true;
                else 
                    AOMinusOne = false;

I have some syntax errors....
Cannot see what....

Thank you for your help !

[NinjaTrader_JoshP]

if (AO().AOValue[1] < AO().AOValue[2])

[jed77]

OH !
Thank you

and, in order to avoid the problem of the "index out of range" I should do like that :

if ((AO().AOValue[Math.Min(CurrentBar, 1)] < AO().AOValue[Math.Min(CurrentBar, 2)]))
                    AOMinusOne = true;
                else 
                    AOMinusOne = false;

Is it ?
Thank you.

[NinjaTrader_JoshP]

Or you can just do

if (CurrentBar < 2)
     return;

at the start of the OnBarUpdate() method.

[jed77]

Ok, thank you !

I still have a diamond at the high of each bar....

Any ideas ?

if (CurrentBar < 2)
                     return;
            
            if (FirstTickOfBar) {
                
                if ((AO().AOValue[1] < AO().AOValue[2]))
                    AOMinusOne = false;
                else 
                    AOMinusOne = true;

.........

if ((AOMinusOne== false) 

                    );
            {
                DrawDiamond("My diamond" + CurrentBar, false, 0, High[0], Color.LightCoral);
            }

[NinjaTrader_JoshP]

You need to work through your logic. If your bool is false it will draw the dot. Likely your bool is never being set to true. Please see this tip on how to debug: http://www.ninjatrader-support2.com/...ead.php?t=3418

[jed77]

Thank you Josh. Very helpful like usually !

I'll debug after lunch

See you

Jed

[jed77]

I did that :

if ((AO().AOValue[1] < AO().AOValue[2]))
                    AOMinusOne = false;
                Print ("AOMinusOne rouge");

And it seems that on each bar, my bool is false....
What do you mean by :

Likely your bool is never being set to true.

Thanks
Jed

[NinjaTrader_JoshP]

What I mean is that if on each bar you are setting it to false then of course you will get a draw object on every bar. Only when you set it to true will you not get the draw object. You need to print out your AO values and run calculations by hand to compare with. That way you can understand your code better.

[jed77]

For me red is false, green is true.
if value of AO of the previous bar is < of the value of the bar before, AO is red, is it right ?

For me red is false, green is true.

So I want the AO value (AOMinusOne) to be false only if AO().AOValue[1] < AO().AOValue[2]
Then, I want to print the diamond.

What am I doing wrong ?

Jed

[NinjaTrader_JoshP]

Jed,

I do not recall the code in the AO. Your logic is only looking at the actual AO value, nothing to do with the color of the AO. When the AO's value of previous bar is less than the AO's value of the bar before that is when you will set to false.

[jed77]

Right, I understand.

Solved my problem, it was mainly a syntax problem....
Here's the right piece of code :

if (FirstTickOfBar) {
                
                if  (AO().AOValue[1] < AO().AOValue[2])
                    {AOMinusOne = false;}
                
                else 
                    {AOMinusOne = true;}

I'll continue on the rest of the code and will come back to you later.

Thank you very much, your help is very precious !
Jed

[bctrader]

Hi all.

Jed, are you coding to paint a buy/sell indicator for the AO on the price chart itself?