Totally noob question about barsago

[caldolegare]

Ok let's say I want to compare the current MACD value to the previous value:

double macd1 = MACD(period1, period2, smooth).Avg[0];
double macd2 = MACD(period, period2, smooth).Avg[1];

if (macd1<macd2)
{do something}

macd1 seems to be computing fine but macd2 is not.

Where am I messing up? Thanks!

[mrlogik]

I think...

[FONT=Courier New][SIZE=2][FONT=Courier New][SIZE=2][FONT=Courier New][SIZE=2][COLOR=#0000ff][FONT=Courier New][SIZE=2][COLOR=#0000ff][FONT=Courier New][SIZE=2][COLOR=#0000ff]double[/COLOR][/SIZE][/FONT][/COLOR][/SIZE][/FONT][/COLOR][/SIZE][/FONT][FONT=Courier New][SIZE=2][FONT=Courier New][SIZE=2] macd2 = MACD(period, period2[/SIZE][/FONT][/SIZE][/FONT][FONT=Courier New][SIZE=2][FONT=Courier New][SIZE=2], smooth[/SIZE][/FONT][/SIZE][/FONT][FONT=Courier New][SIZE=2][FONT=Courier New][SIZE=2])[COLOR=Red][1][/COLOR].Avg[/SIZE][/FONT][/SIZE][/FONT][FONT=Courier New][SIZE=2][FONT=Courier New][SIZE=2]; [/SIZE][/FONT][/SIZE][/FONT][/SIZE][/FONT][/SIZE][/FONT]

[NinjaTrader_Ben]

Hello,


Try adding this before the condition:

Print(macd1 + " macd1");
Print(macd2 + " macd2");

Then go to Tools>Output Window and see what prints when the strategy is running.

If that doesn't work try printing your macd parameters before they are assigned to macd1 and macd2.

Another possible issue may be that you do not have enough bars to calculate the macd. Please review this link:

http://www.ninjatrader-support2.com/vb/showthread.php?t=3170

[caldolegare]

When I put this in I get nothing

Print(macd1 + " macd1");
Print(macd2 + " macd2");

If I remove the macd2 line I get all the values for macd1 in the output window.

[mrlogik]

I think what ben means is the following

Print("MACD1 = " + macd1.ToString());
Print("MACD2 = " + macd2.ToString());

Did you try what I suggested?

[NinjaTrader_Ben]

Hello,



The issue is probably arising from not adding if(CurrentBar > some_number) return; at the top of the OnBarUpdate() block.

[caldolegare]

Thanks that worked perfectly.

Hello,



The issue is probably arising from not adding if(CurrentBar > some_number) return; at the top of the OnBarUpdate() block.