Buy sell signals

[radhmu978]

Dear NT7 support team,

I have developed an indicator for NT7 version and trying to generate buy and sell signals based on OHLC data. I completed the code and compiled it successful. But, I'm not seeing the BUY / SELL arrows in chart. Could you please help me to get this issue resolved. Any sample code will also help.

Thankyou

[NinjaTrader_ChelseaB]

Hello radhmu978,

Welcome to the NinjaTrader forums!

The OHLC can be obtained by calling the CurrentDayOHL() indicator and the current Close[0].

https://ninjatrader.com/support/helpGuides/nt7/current_day_ohl.htm

https://ninjatrader.com/support/helpGuides/nt7/close.htm

You can draw arrows with DrawArrowUp() and DrawArrowDown() when the condition is true.

https://ninjatrader.com/support/helpGuides/nt7/drawarrowup.htm

https://ninjatrader.com/support/helpGuides/nt7/drawarrowdown.htm

You can send signals to a calling host script by setting a plot value in an indicator. Below is a link to an example.

https://ninjatrader.com/support/forum/showthread.php?p=436286#post436286

I am also including a link to a forum post with helpful information about getting started with NinjaScript and C#.

https://ninjatrader.com/support/forum/forum/ninjatrader-7/indicator-development-aa/94724-help?p=775232#post775232

One note, if you are just starting out, I would highly recommend starting with NinjaTrader 8 and not NinjaTrader 7 so your code doesn't quickly become obsolete.
NinjaTrader 7 is no longer in active development and we are no longer considering new feature requests for NinjaTrader 7. Main development has shifted to our flagship platform NinjaTrader 8. This does mean updates from brokerages, data feeds, or operating systems that require an update in NinjaTrader will not be implemented in NinjaTrader 7 and may cause an interruption in service.

While there is not a set ETA for the complete discontinuation of NinjaTrader 7, we highly recommend transitioning to NinjaTrader 8 as soon as possible before NinjaTrader 7 reaches its end of life to prevent interruption of service.

Click below to download NinjaTrader 8.

http://ninjatrader.com/GetStarted

I'm also including a link to a forum post with the same information about getting started with NinjaScript and C# for NinjaTrader 8.

https://ninjatrader.com/support/forum/forum/ninjatrader-8/indicator-development/97575-sample-scripts?p=786040#post786040

[radhmu978]

Thank you. Will check the links. I have a pinescript that gives BUY/SELL alert in trading view. I'm trying to implement the same in NT7 and NT8. NT7 indicator that i creatd is displaying the plot in the bottom of the chart. Could you please check the screen cast link from trading view and NT7 chart. I want the match the output of tradingview.

https://www.screencast.com/t/8RS8SBF5T - NT7 chrt

https://www.screencast.com/t/JcolLFbD9BT - Tradingview

[NinjaTrader_ChelseaB]

Hello radhmu978,

I wouldn't be able to advise on how another platform works or if the connection to data is the same data source.

You can use prints however, to find out what is different. Such as printing the time of the bar and the open, high, low, and close. Keep in mind different data providers may have slightly different data.

Below is a link to a forum post that demonstrates how to use prints to understand behavior.

https://ninjatrader.com/support/forum/forum/ninjatrader-7/strategy-development-aa/99209-date-conditions-not-working?p=791121#post791121

[radhmu978]

Thank you, will check. I want to know the functions that i can use in NT7 to display the buy, sell arrows with lable. include the code snippet from trading view pine script.

plotarrow(series = isAbove ? 1 : isBelow ? -1 : na, colorup= color.lime, colordown = color.orange, maxheight=30)
plotshape(series = isAbove ? 1 : na ,location = location.belowbar,color = color.green, style = shape.labelup, text = "BUY", textcolor = color.white)
plotshape(series = isBelow ? 1 : na ,location = location.abovebar,color = color.orange, style = shape.labeldown, text = "SELL", textcolor = color.white)

[NinjaTrader_ChelseaB]

Hello radhmu978,

You can draw arrows with DrawArrowUp() and DrawArrowDown() when the condition is true.
(Noted in post #2)
https://ninjatrader.com/support/help...rawarrowup.htm
https://ninjatrader.com/support/help...warrowdown.htm

For a label you can use DrawText().

https://ninjatrader.com/support/helpGuides/nt7/drawtext.htm

[radhmu978]

Where exactly I need to place the drawArrow functions? When i started the indicator, I created 2 plot in indicator wizard


protected override void Initialize()
{
Add(new Plot(Color.FromKnownColor(KnownColor.OrangeRed), PlotStyle.TriangleDown, "Sell"));
Add(new Plot(Color.FromKnownColor(KnownColor.Green), PlotStyle.TriangleUp, "Buy"));
Overlay = true;
}

but I need to draw up/down arrows

DrawArrowDown(CurrentBar.ToString(), true, 0, Buy, Color.Blue);
DrawArrowUp(CurrentBar.ToString(), true, 0, Sell, Color.Red);

[NinjaTrader_ChelseaB]

Hello radhmu978,

In the action block of the condition that when true you want to see arrows.

if (/* condition here */)
{
DrawArrowDown(CurrentBar.ToString(), true, 0, High[0] + 2 * TickSize, Color.Blue);
}

[radhmu978]

I see some error in during the runtime, issue is with the CurrentDayOHL

Made it to line 84
Error on calling 'OnBarUpdate' method for indicator 'RMPriceAction' on bar 1: Object reference not set to an instance of an object.

closeOrg[0] = (CurrentDayOHL().CurrentOpen[0] + CurrentDayOHL().Close[0] + CurrentDayOHL().CurrentLow[0] + CurrentDayOHL().CurrentHigh[0])/4;

If you want I can send the full source code, including the pinescript logic that i'm trying to implement in NT7, Could you please check and let me know where I went wrong? is there an email i can use to send the details?

[NinjaTrader_ChelseaB]

Hello radhmu978,

CurrentDayOHL().Close[0], is this meant to be Close[0]?

https://ninjatrader.com/support/helpGuides/nt7/current_day_ohl.htm

Make a new script to test that line of code.

Print((CurrentDayOHL().CurrentOpen[0] + Close[0] + CurrentDayOHL().CurrentLow[0] + CurrentDayOHL().CurrentHigh[0])/4);

Does this also have the error in the new test script?

What is closeOrg? Is this a custom series? Has this been instantiated as a new DataSeries in Initialize()?

https://ninjatrader.com/support/helpGuides/nt7/dataseries_class.htm

[radhmu978]

ok, this line is working perfectly. Looks like CurrentDayOHL().Close[0] is the issue, I replaced the line with Close[0] now

[radhmu978]

Still the same issue, test script is working but i still see exception

Print("Made it to line 84");
closeOrg[0] = ((CurrentDayOHL().CurrentOpen[0] + Close[0] + CurrentDayOHL().CurrentLow[0] + CurrentDayOHL().CurrentHigh[0])/4);
//Print((CurrentDayOHL().CurrentOpen[0] + Close[0] + CurrentDayOHL().CurrentLow[0] + CurrentDayOHL().CurrentHigh[0])/4);

##output window
Made it to line 68
Made it to line 84
Error on calling 'OnBarUpdate' method for indicator 'RMPriceAction' on bar 1: Object reference not set to an instance of an object.

[NinjaTrader_ChelseaB]

Hello radhmu978,

If the test script is working, then its not the call to the CurrentDayOHL indicator likely causing the issue.

I was not able to confirm, what is closeOrg?
Is this a custom series?
Has this been instantiated as a new DataSeries in Initialize()?
https://ninjatrader.com/support/help...ries_class.htm

[radhmu978]

Yes, it is a custom dataseries, I did not initialize. Do i need get, set for all custom dataseries?
close_org will hold the average and open_org has a recursive, self referencing data. Any reference on how to assign the recursive self referencing variable?

##pinescript Snippet##
open_org = 0.0
close_org = (open + high + low + close ) / 4.0
open_org:= (nz(open_org[1]) + close_org[1] ) / 2.0

[NinjaTrader_ChelseaB]

Hello radhmu978,

Custom data series have to be initialized to an object in the Initialized method. Please see the help guide for the example.

No, you will not have to have an auto-get unless the series is meant to be accessed from another script. But the variable does have to have a data series object assigned to it.