Accessing indicator properties inside another indicator

[CaptainAmericaXX]

Hello,
I've written a simple indicator that sets price highs and lows. I'd like to reuse those values as input for other indicators. Unfortunately when I try to access those values I'm only getting back the Close[0]. What could cause that?
Here's the code:

public class A1PNV : Indicator
    {
        #region Variables

            private DataSeries pricePeak;
            private DataSeries priceValley;

        #endregion

        protected override void Initialize()
        {
            Overlay                = true;

            pricePeak            = new DataSeries(this);
            priceValley            = new DataSeries(this);
        }

        protected override void OnBarUpdate()
        {
            pricePeak.Set(Peak_Value(High,Open,Close));
            priceValley.Set(Valley_Value(Low, Open, Close));
        }

        #region Properties

        [Browsable(false)]    // this line prevents the data series from being displayed in the indicator properties dialog, do not remove
        [XmlIgnore()]        // this line ensures that the indicator can be saved/recovered as part of a chart template, do not remove
        public DataSeries Price_Peak
        {
            get { return Values[0]; }
        }
        [Browsable(false)]    // this line prevents the data series from being displayed in the indicator properties dialog, do not remove
        [XmlIgnore()]        // this line ensures that the indicator can be saved/recovered as part of a chart template, do not remove
        public DataSeries Price_Valley
        {
            get { return Values[1]; }
        }
        #endregion

Inside the second indicator I have:

protected override void OnBarUpdate()
{
            A1PNV pnv = A1PNV();
            double pp = pnv.Price_Peak[0];
}

pp returns the Close[0].
The A1PNV indicator works fine on its own. It's only when I try to reference it in another indicator that I'm having an issue. Any help would be greatly appreciated.

[NinjaTrader_Jesse]

Hello CaptainAmericaXX,

This is due to using "DataSeries" instead of using a Plot and also the public properties you created. You are mixing two separate concepts here, I will explain this in more detail.

private DataSeries pricePeak;

You have created a private DataSeries object to store data. The problem is that you are using the private variable name: pricePeak but this is not the same as Price_Peak, your public property.

The public properties you are using are referencing the Plots your indicator has, but you didn't add any so there is nothing to reference here:

return Values[0];
return Values[1];

When you try to get the value, you are referencing a empty plot which will default to the close price. From what you provided, it seems you have laid this out as the standard plotting format where you plot from indicator A, then call indicator "A" from another script to retrieve its value. If that is what you were trying to follow, you need to remove the private DataSeries you created and instead use two plots:
https://ninjatrader.com/support/help...hlightsub=Plot

protected override void Initialize()
{
    Add(new Plot(Color.Blue, "Price_Peak"));
    Add(new Plot(Color.Blue, "Price_Valley"));
}

Then in OnBarUpdate, make sure to use the public property you created:

Price_Peak.Set(Peak_Value(High,Open,Close));

If you specifically wanted to use a DataSeries or other type as a public property, we have a sample showing how that can be used here: https://ninjatrader.com/support/help...alues_that.htm

I look forward to being of further assistance.

[CaptainAmericaXX]

THANK YOU Jesse! Thanks for catching my spelling errors in the private variable/properties and for teaching me the difference in the Plots and DataSeries values. That solved A LOT of recurring problems in my coding.