No overload for bar method

[bauerjj10]

I am looking for help and an explanation of what I am doing wrong here with my code. I have very little experience with coding and am attempting to learn ninjascript on my own so I apologize if this is a simple error. Below is my code and the error I am recieving. Thanks!

No overload for method "barvolume" takes 0 arguments. CS1501

namespace NinjaTrader.NinjaScript.Indicators
{
	public class JBSwingbars : Indicator
	{
		SMA _volsma;
		VOL _volume;
		
		protected override void OnStateChange()
		{
			if (State == State.SetDefaults)
			{
				Description									= @"Plots a dot at an area where HH/HL transitions to LH/LL.";
				Name										= "JBSwingbars";
				Calculate									= Calculate.OnBarClose;
				IsOverlay									= false;
				DisplayInDataBox							= true;
				DrawOnPricePanel							= true;
				DrawHorizontalGridLines						= false;
				DrawVerticalGridLines						= false;
				PaintPriceMarkers							= true;
				ScaleJustification							= NinjaTrader.Gui.Chart.ScaleJustification.Right;
				//Disable this property if your indicator requires custom values that cumulate with each new market data event. 
				//See Help Guide for additional information.
				IsSuspendedWhileInactive					= true;
				AddPlot(new Stroke(Brushes.DodgerBlue, 2), PlotStyle.Dot, "Buy");
				AddPlot(new Stroke(Brushes.Red, 2), PlotStyle.Dot, "Sell");
				
				int _currentplot;
				int _lastplot;
				
			}
			else if (State == State.Configure)
			{
				AddDataSeries(Data.BarsPeriodType.Day, 1);
				_volume = VOL();
				_volsma = SMA(_volume,576);     // SMA on volume for the past 2 days on 5min chart
			}
		}

		protected override void OnBarUpdate()
		{
			//  Check to make sure there are enough bars on chart.
			if (base.CurrentBar < 576)
			{
				return;
			}
			// If the volume is not greater than moving average during then do not trade.
			if (barvolume() == false)
			{
				return;
			}
			//  If current bar shows sell signal plot a red dot.
			if (_currentplot != _lastplot && _currentplot == -1)
			{
				// place code here to draw dot on chart.
			}
			//  If current bar shows a buy signal plot a blue dot.
			if (_currentplot != _lastplot && _currentplot == 1)
			{
				// place code here to draw dot on chart.
			}
		}

		#region methods
		
		bool barvolume(double _volume, double _volsma)  //If the volume is not above the SMA do not plot a dot.
		{
			get	{return _volume > _volsma;}
		}

		#endregion

[koganam]

I am looking for help and an explanation of what I am doing wrong here with my code. I have very little experience with coding and am attempting to learn ninjascript on my own so I apologize if this is a simple error. Below is my code and the error I am recieving. Thanks!

No overload for method "barvolume" takes 0 arguments. CS1501

namespace NinjaTrader.NinjaScript.Indicators
{
    public class JBSwingbars : Indicator
    {
        SMA _volsma;
        VOL _volume;
        
        protected override void OnStateChange()
        {
            if (State == State.SetDefaults)
            {
                Description                                    = @"Plots a dot at an area where HH/HL transitions to LH/LL.";
                Name                                        = "JBSwingbars";
                Calculate                                    = Calculate.OnBarClose;
                IsOverlay                                    = false;
                DisplayInDataBox                            = true;
                DrawOnPricePanel                            = true;
                DrawHorizontalGridLines                        = false;
                DrawVerticalGridLines                        = false;
                PaintPriceMarkers                            = true;
                ScaleJustification                            = NinjaTrader.Gui.Chart.ScaleJustification.Right;
                //Disable this property if your indicator requires custom values that cumulate with each new market data event. 
                //See Help Guide for additional information.
                IsSuspendedWhileInactive                    = true;
                AddPlot(new Stroke(Brushes.DodgerBlue, 2), PlotStyle.Dot, "Buy");
                AddPlot(new Stroke(Brushes.Red, 2), PlotStyle.Dot, "Sell");
                
                int _currentplot;
                int _lastplot;
                
            }
            else if (State == State.Configure)
            {
                AddDataSeries(Data.BarsPeriodType.Day, 1);
                _volume = VOL();
                _volsma = SMA(_volume,576);     // SMA on volume for the past 2 days on 5min chart
            }
        }

        protected override void OnBarUpdate()
        {
            //  Check to make sure there are enough bars on chart.
            if (base.CurrentBar < 576)
            {
                return;
            }
            // If the volume is not greater than moving average during then do not trade.
            if (barvolume() == false)
            {
                return;
            }
            //  If current bar shows sell signal plot a red dot.
            if (_currentplot != _lastplot && _currentplot == -1)
            {
                // place code here to draw dot on chart.
            }
            //  If current bar shows a buy signal plot a blue dot.
            if (_currentplot != _lastplot && _currentplot == 1)
            {
                // place code here to draw dot on chart.
            }
        }

        #region methods
        
        bool barvolume(double _volume, double _volsma)  //If the volume is not above the SMA do not plot a dot.
        {
            get    {return _volume > _volsma;}
        }

        #endregion

Your definition of the method requires 2 parameters. You are now trying to call the method with no parameters. The compiler is telling you that you cannot do that.

Wherever you have barvolume(), change it to the correct call. Try: barvolume(_volume, _volsma)

What I have written is in accordance with how you have written things. Your writing is not a good idea, as you are using the same variable names to define signatures as you are using to perform actions. It makes it confusing to know which is which.

[bauerjj10]

Thanks for your help. Since I am very new to programming and only learning from youtube videos and what I can find in the ninjatrader forum and NT8 manual it has been a slow process.

Could you help me understand the proper way to code this?

Does this look better?

if (barvolume(_volume,_volsma) == false)
{
return;
}


bool barvolume(double x, double y)
{
get {return x > y;}
}

[NinjaTrader_ChelseaB]

Hello bauerjj10,

Yes, this would match the parameters for the call to the bool method.

When using a bool method and always giving new input, the get (and set) no longer become necessary.

Below I am including a publicly available link to a 3rd party educational site on bool methods and returns.

https://www.dotnetperls.com/bool-return

Also, below is a link to a forum post with helpful information about getting started with NinjaScript. Many of these resources in this post you have found.

http://ninjatrader.com/support/forum/showthread.php?p=493678#post493678

[koganam]

You might want to write your method as:

private bool barvolume(double x, double y)
{
   return x > y;
}