IsFalling problem.

[KennyK]

Sorry this should have been posted in the NT8 section.

Hi, I have been trying to use "IsFalling" in an indicator code, and it just isn't working for me.
I must be doing something wrong, but I just can't figure it out. I have tried it a couple of ways as follows:
if (IsFalling(SMA(Typical,3))) && Close[0]>BP[0]);
BarBrush = TransitionUp;

if (IsFalling(BP)) && Close[0]>BP[0]);
BarBrush = TransitionUp;

if (BP[0]<BP[1] && Close[0]>BP[0]);
BarBrush = TransitionUp;

You should know, BP[0] = SMA(Typical, 3)[0];

All 3 of these examples don't work.
I have had trouble when trying to use IsRising / IsFalling in the past.
Can you see what I have done wrong and how to correct it?

Thanks,
Ken.

[NinjaTrader_PaulH]

Hello KennyK,

Thanks for your post.

The conditional statements look like they have a semi-colon ";" at the end which would prevent them from working as intended.

I would advise coding in this manner to help clarify:

if (Conditional statements)
{
action statements;
}

The "curley braces" { } would contain all of the actions to perform be they 1 or more action statements. If you only have 1 action statement the {} are not technically needed but they may help you develop a coding consistency. For example:

if (IsFalling(SMA(Typical,3))) && Close[0]>BP[0])
{
BarBrush = TransitionUp;
}

[KennyK]

Many Thanks

Thanks Paul you bloody legend!
That's got it sorted.