Multi-Instrument Exit Trigger

[John833]

I'm running several instruments at the same time. When a profit target is reached would like to change a condition from "false" to "true".
Unfortunately this doesn't work... any thoughts? Thanks

if (Positions[0].GetProfitLoss(Closes[0][0], PerformanceUnit.Currency)
+ Positions[1].GetProfitLoss(Closes[1][0], PerformanceUnit.Currency)
+ Positions[2].GetProfitLoss(Closes[2][0], PerformanceUnit.Currency)
+ Positions[3].GetProfitLoss(Closes[3][0], PerformanceUnit.Currency)
+ Positions[4].GetProfitLoss(Closes[4][0], PerformanceUnit.Currency) > 1000


&& ProfitLimit == false
)
{
ProfitLimit = true;
}

[NinjaTrader_ChelseaB]

Hello John833,

What does this value evaluate as?

Make a print of this.

Print(Positions[0].GetProfitLoss(Closes[0][0], PerformanceUnit.Currency)
+ Positions[1].GetProfitLoss(Closes[1][0], PerformanceUnit.Currency)
+ Positions[2].GetProfitLoss(Closes[2][0], PerformanceUnit.Currency)
+ Positions[3].GetProfitLoss(Closes[3][0], PerformanceUnit.Currency)
+ Positions[4].GetProfitLoss(Closes[4][0], PerformanceUnit.Currency));

What does this print as when you are expecting the condition to be true?

[koganam]

I'm running several instruments at the same time. When a profit target is reached would like to change a condition from "false" to "true".
Unfortunately this doesn't work... any thoughts? Thanks

if (Positions[0].GetProfitLoss(Closes[0][0], PerformanceUnit.Currency)
+ Positions[1].GetProfitLoss(Closes[1][0], PerformanceUnit.Currency)
+ Positions[2].GetProfitLoss(Closes[2][0], PerformanceUnit.Currency)
+ Positions[3].GetProfitLoss(Closes[3][0], PerformanceUnit.Currency)
+ Positions[4].GetProfitLoss(Closes[4][0], PerformanceUnit.Currency) > 1000


&& ProfitLimit == false
)
{
ProfitLimit = true;
}

What exactly does the clause "doesn't work" mean in your context? What are you expecting to see, and what are you seeing that does not look correct?

[John833]

Hi NinjaTrader_ChelseaB & koganam
I've made a print, the output window shows the unrealised p/l of the positions held.
When the unrealised p/l reaches over $1000 then ProfitLimit should be 'true'.

The problem I have is as soon as Position[0] has a position, ProfitLimit becomes true immediately before the p/l has reached $1000.

So I have either a problem elsewhere in my code OR there is something wrong with the code below?

[NinjaTrader_ChelseaB]

Hello John833,

What is coming out from that print?

Do you have other code that sets the ProfitLimit bool that you have not shared with us?

[John833]

Hi NinjaTrader_ChelseaB

Managed to sort out the problem(s), I had errors in Initialise and some poor code constructions.

Thanks & regards!