Newbie question about "if" and "else"

[nikolaalx]

Hi,
I am slowly getting into the basics of the NT editor.

I am able now to create rules and follow the format for inserting/adding/editing of variables.

I am trying to figure out how to optimize a little bit the codes that I am creating ...as I reckon that though they are functional, might not be the best way in terms of performance and load.


This is why I want to ask on an advice of how the optimum code would be for the following:

if(Time[0].Month == 1)
{
Variable5 = 1;
}

else if(Time[0].Month == 2)
{
Variable5 = 0;
}

Should I make it with "else" within the first {} and get rid of the whole "else if" new condition?

Thanks

[koganam]

Hi,
I am slowly getting into the basics of the NT editor.

I am able now to create rules and follow the format for inserting/adding/editing of variables.

I am trying to figure out how to optimize a little bit the codes that I am creating ...as I reckon that though they are functional, might not be the best way in terms of performance and load.


This is why I want to ask on an advice of how the optimum code would be for the following:

if(Time[0].Month == 1)
{
Variable5 = 1;
}

else if(Time[0].Month == 2)
{
Variable5 = 0;
}

Should I make it with "else" within the first {} and get rid of the whole "else if" new condition?

Thanks

You cannot have an else statement directly in an if block. What you have written is the correct way to write it.

[NinjaTrader_Bertrand]

nikolaalx, you could even remove the braces in single line assignments and simplify a bit to -

if (Time[0].Month == 1)
	Variable5 = 1;

else if(Time[0].Month == 2)
	Variable5 = 0;

[arbuthnot]

If I could add something, if there are only two options in the conditional, say it matters only if the months are even or odd, you don't need the 'else if', just an 'else':

if ( [I]... month is an even number ... [/I])

    Variable5 = 1;

else Variable5 = 0; // There's only one other option: the month number is odd

Also, at the end of a list, when you've exhausted all the options (say you've come to December), then you only need an 'else' on its own.