stoploss modification

[zachj]

I looked over the sample stoploss modification but its for long only, how would u set it up for combination w a short? Should there be a seperate reset if flat for both sides? I tried the below but only one of the stops triggers orders.

	SetStopLoss("EnterLong", CalculationMode.Ticks, stopticks, true);//100
			SetStopLoss("EnterShort", CalculationMode.Ticks, stopticksS, true);//85
                        SetProfitTarget("EnterLong", CalculationMode.Ticks, profittarget);//79
			SetProfitTarget("EnterShort",CalculationMode.Ticks, profittargetS);//55
			
        }

        protected override void OnBarUpdate()
		{
#region Stoploss Modification			
		// Resets the stop loss to the original value when all positions are closed
			
			if (Position.MarketPosition == MarketPosition.Flat)
			{
				SetStopLoss("EnterLong", CalculationMode.Ticks, stopticks, true);
			}
			
			// If a long position is open, allow for stop loss modification
			else if (Position.MarketPosition == MarketPosition.Long)
			{
if (Close[0] >= Position.AvgPrice + (TickSize*10))
				{
					SetStopLoss("EnterLong", CalculationMode.Price, Close[0] - (TickSize*15), true);
			        }
                        }
			
	if (Position.MarketPosition == MarketPosition.Short)
			{
			
				if (Close[0] <= Position.AvgPrice - (TickSize*12))
				{
				SetStopLoss("EnterShort", CalculationMode.Ticks, TickSize*15, true);
				}
			}

[NinjaTrader_CalH]

Hello ZachJ,

From your script, I see that you are missing a closing } after the SetStopLoss for the long position check and could be causing a logic issue with the code.

[zachj]

I just missed it went pasting in here, that's not the issue. Edited post. Got anything else?

[NinjaTrader_CalH]

Thanks Zachj

Are you saying that the MarketPosition.Long works but the Short does not when a trade is active?

[zachj]

When backtesting..in my trades tab there will be a bunch of stop modifications triggered on long side but none for short side. Only way I can get shorts to trigger on short side is from the fixed stop in initialize.

[NinjaTrader_CalH]

Zachj,

Can you attach the strategy so that I can test this on my end?

[zachj]

I think I got it working. Just to make sure though, should I have seperate code as I have below to reset the Long and then another to reset the Short position? The "fromEntrySignal" directs each accordingly?

if (Position.MarketPosition == MarketPosition.Flat)
			{
				SetStopLoss("EnterLong", CalculationMode.Ticks, 100, true);
			}
			
if (Position.MarketPosition == MarketPosition.Flat)
			{
				SetStopLoss("EnterShort", CalculationMode.Ticks, 85, true);
			}

[NinjaTrader_CalH]

Correct, you would be better off on combining those two statements as each StopLoss has its own fromEntrySignal

[zachj]

You meant NOT combining right?

[NinjaTrader_CalH]

I meant TO combine them as they will process the same way as they do now but without the extra logic to run a test for MarketPosition.

[zachj]

I have a different stoploss ticks for short and long so if I combined them it actually would not process the same?

[NinjaTrader_CalH]

Not quite how you're thinking it will work.

Since you are using different fromEntrySignals the StopLoss's that are being called will have their own separate logic for the entries.

If you combined them you would be telling the system that any Entry Signal with those names to use the associated parameters.

[zachj]

Not quite how you're thinking it will work.

Since you are using different fromEntrySignals the StopLoss's that are being called will have their own separate logic for the entries.

If you combined them you would be telling the system that any Entry Signal with those names to use the associated parameters.

I don't want them to use any Entry Signal, I am wanting the stop for the Entry signal for the long to use its associated parameters and vice versa for the short. The long has a stop of 100 ticks and the short 85 ticks. So I need to keep them seperate?

[NinjaTrader_CalH]

Zachj,

if (Position.MarketPosition == MarketPosition.Flat)
	{
		SetStopLoss("EnterLong", CalculationMode.Ticks, 100, true);
	}
			
if (Position.MarketPosition == MarketPosition.Flat)
	{
		SetStopLoss("EnterShort", CalculationMode.Ticks, 85, true);
	}

OR

if(Position.MarketPosition == MarketPosition.Flat)
{
     SetStopLoss("EnterLong", CalculationMode.Ticks, 100, true);
     SetStopLoss("EnterShort", CalculationMode.Ticks, 85, true);
}

Both will produce the same results the bottom has just one less logic to calculate.

[zachj]

Oh that's all you were saying! Sorry I thought you meant use the same stop for the long and short. Thanks man