Ending Ninjascript strategy

[[email protected]]

ending ninjascript

Thanks Ray,
How do I do the Strategy Running false thing, once I have achieved the profit target?

[[email protected]]

ending ninjascript

Sorry Ray,
I see now where you showed me after my code.
Thanks,
Jim

[[email protected]]

ending ninjascript

Hi Ray,
I have the code entered as below and it doesn't work. I get past $100.00 in profit, and the strategy keeps running/keeps sending orders, etc.


// If the profit on real-time trades is > $100 stop trading
if (Performance.RealtimeTrades.TradesPerformance.Curr ency.CumProfit > 100)
Running = false;

[NinjaTrader_Ray]

Try "return" after the check for $100.

[[email protected]]

ending ninjascript

Are you saying instead of Running = false, use return?

[NinjaTrader_Ray]

Yes that is correct.

[[email protected]]

ending ninjascript

Why won't this exit a long position that reaches > $100 profit, and stop the strategy from running.
It isn't doing either thing.

// If the profit on real-time trades is > $100 stop trading
if (Position.MarketPosition == MarketPosition.Long && Performance.RealtimeTrades.TradesPerformance.Curre ncy.CumProfit > 100)
ExitLong("lg");
if (Position.MarketPosition == MarketPosition.Short && Performance.RealtimeTrades.TradesPerformance.Curre ncy.CumProfit > 100)
ExitShort("sht");
if (Performance.RealtimeTrades.TradesPerformance.Curr ency.CumProfit > 100)
return;

[NinjaTrader_Ray]

You will need to debug your code.

For example,

if (Position.MarketPosition == MarketPosition.Long && Performance.RealtimeTrades.TradesPerformance.Curre ncy.CumProfit > 100)
ExitLong("lg");

- Can you confirm this "if" branch is entered?
- What's the value of "CumProfit" property etc... does it ever go above 100?

[[email protected]]

ending ninjascript

I have
CalculateOnBarClose = false;
And I see the unrealized profit go above $100, so it seems it should exit and stop the strategy from running.

[NinjaTrader_Ray]

CumProfit is realized PnL not unrealized. For unrealized, see Position.GetProfitLoss().

http://www.ninjatrader-support.com/HelpGuideV6/GetProfitLoss.html

[[email protected]]

ending ninjascript

The results of closed trades do not seem to be moving into the realized column in Version 6.5?

[[email protected]]

ending ninjascript

CumProfit is realized PnL not unrealized--
In order to stop running a strategy once accumulated profit has reached a certain target level, it would seem that unrealized p&L would need to be adding to or subtracting from the realized P&L while the strategy is in an open trade.
Is that what is supposed to be happening in the realized p&l column?
Thanks,
Jim

[NinjaTrader_Ray]

An open trade is not "Realized" PnL since the trade is not closed. Only closed trades make up "Realized" PnL.

[[email protected]]

ending ninjascript

So is there coding that would allow me to check unrealized P&L plus realized p&L to see if a certain CumProfit has been attained in order to close open positions and stop the strategy from running?

[NinjaTrader_Ray]

Add the CumProfit to the Position.GetProfitLoss().