Where should classes be instantiated in indicator code?

[FREEN]

Where should classes be instantiated in indicator code so that no more than one (1) instance is created? I guess the question also can be phrased; what part of indicator code is equivalent to a constructor? I noticed "if (State == State.Configured)" might trigger many instances. Can I make "my own" constructor without causing code conflicts? Any best practice?

//ALT 1:

DateTime myTime;

if (State == State.Configure)
{
     myTime = new DateTime();
}


//ALT2:

public MyIndicatorConstructor()
{
    myTime = new DateTime();
}

Sorry if my search for the answere in the documentation might have been scarce.

[FREEN]

A follow up question;

If I declare and instantiate in one row, where would be the right place to set "one time" properties of the class? Would this be best practice?

 public class A190808Xaia : Indicator
 {
  #region Fields & Initialization

  private MyClass mc = new MyClass();


  protected override void OnStateChange()
  {
   if (State == State.SetDefaults)
   {

   }
   else if (State == State.Configure)
   {         
    mc.MyDouble = 2.0;
   }
  }


  more code....
 }

[NinjaTrader_Kate]

Hello FREEN,

Thank you for your reply.

I'd recommend setting those "one time" properties in either State == State.SetDefaults or State == State.Configure.

Please let us know if we may be of further assistance to you.

[FREEN]

Thanks Kate! And declaration/instantiation should be done in one line in the #region Fields & Initialization? (Since instantiations elsewise might be triggered erratically and cause multiple instances?) Correct?

[NinjaTrader_Kate]

Hello FREEN,

Thank you for your reply.

You'd at least want to declare them there, and usually instantiate them as well.

Please let us know if we may be of further assistance to you.

[koganam]

A follow up question;

If I declare and instantiate in one row, where would be the right place to set "one time" properties of the class? Would this be best practice?

public class A190808Xaia : Indicator
{
#region Fields & Initialization

private MyClass mc = new MyClass();


protected override void OnStateChange()
{
if (State == State.SetDefaults)
{

}
else if (State == State.Configure)
{
mc.MyDouble = 2.0;
}
}


more code....
}

If you are going to declare the class at class level, instantiate one time properties there.

private MyClass mc = new MyClass(){property1 = foo; property2 = bar; //etc};

[FREEN]

I made this little dll in order to get clear on how NT instantiates:

    public class NTtestClass
    {
        public NTtestClass()
        {
            System.Windows.Forms.MessageBox.Show("This is constructor!");
        }
    }

In the process of loading the indicator utilizing this class onto a chart, the MessageBox pops up (= the constructor is called) 4 times if instantiated in the class, 4 times in State.SetDefaults, but only once during State.Configure.

After having unintendeded background processes started by multiple (4) firings of constructors it´s clear to me that instatiations should be made during State.Configure and no where else. Obviously same goes for event subscription.