Enhanced On Balance Volume Indicator

[Elliott Wave]

Actually, your version is good, just missing one little (or may be big) thing - whenever you divide something , ALWAYS check your divisor !=0.
I corrected your mistake.

Thanks a lot. I knew it was probably something small I was overlooking. I've never considered the divide by zero error, but I'll have to make sure I do from now on.

[T2020]

Thank you both ! for taking the time to work on this .
Much appreciated .

[T2020]

Follow up question

The indicator updates on bar completion . I changed one statement like this :
CalculateOnBarClose = false; : ,but there must be something else the needs to changed ,maybe this : if (CalculateOnBarClose) : ??? Nope , lost
again .

[Elliott Wave]

The indicator updates on bar completion . I changed one statement like this :
CalculateOnBarClose = false; : ,but there must be something else the needs to changed ,maybe this : if (CalculateOnBarClose) : ??? Nope , lost
again .

What are you trying to do?
Just set calculate on bar close to false in the indicators windows if you want it to update every tick.

[T2020]

What are you trying to do?
Just set calculate on bar close to false in the indicators windows if you want it to update every tick.

I did ,but it didn't change anything . That's why I thought maybe something
needed to be changed in the code .... ?Does it update every tick for you when you set it that way ?

[roonius]

Here you go

[T2020]

Here you go

Thanks again roonius . I notice that there is an extreme spike in the indicator
right at the beginning of a new bar occasionally ,but resumes normal working
almost immediately . Just something I'm leaving feed back on .
I wish i knew how to do this . I'd be adding moving averages to it , trying
certain period summations of the same formula . I could do all that on my
previous software , unfortunately it didn't have anything remotely as good as
the Ninja chart trader ,which I've come to rely on . Oh well . Thanks again .

[RJay]

Roonius,

I clipped this code from your indicator.

if (CurrentBar == 0)
{
if((High[0]-Low[0])!=0)
{
volUp.Set(Volume[0]*((High[0]-Open[0])/(High[0]-Low[0])));
volDn.Set(Volume[0]*((Open[0]-Low[0])/(High[0]-Low[0])));
} else
{
volUp.Set(0);
volDn.Set(0);
}
} else

if((High[0]-Low[0])!=0)
{

volUp.Set(volUp[1] + Volume[0]*((High[0]-Open[0])/(High[0]-Low[0])));
volDn.Set(volDn[1] + Volume[0]*((Open[0]-Low[0]) /(High[0]-Low[0])));
}

OBVplot.Set(volUp[0] - volDn[0]);



You have this exception in there twice:

if((High[0]-Low[0])!=0)

i don't see any exceptions if ((Open[0]-Low[0])were to equal zero.

It looks like it could pop with an infinite number.


What are your thoughts,


RJay

[roonius]

Roonius,

I clipped this code from your indicator.

if (CurrentBar == 0)
{
if((High[0]-Low[0])!=0)
{
volUp.Set(Volume[0]*((High[0]-Open[0])/(High[0]-Low[0])));
volDn.Set(Volume[0]*((Open[0]-Low[0])/(High[0]-Low[0])));
} else
{
volUp.Set(0);
volDn.Set(0);
}
} else

if((High[0]-Low[0])!=0)
{

volUp.Set(volUp[1] + Volume[0]*((High[0]-Open[0])/(High[0]-Low[0])));
volDn.Set(volDn[1] + Volume[0]*((Open[0]-Low[0]) /(High[0]-Low[0])));
}

OBVplot.Set(volUp[0] - volDn[0]);

You mave this in there twice:

if((High[0]-Low[0])!=0)

i don't see any exceptions if ((Open[0]-Low[0])==0)

It looks like it could pop with an infinite number.


What are your thoughts,


RJay

(Open[0]-Low[0]) is not a divisor

The only divisor we have is High[0] - Low[0]

[RJay]

Variable * 0 / Variable.

Punch it in a calculator and see what happens.

[roonius]

Variable * 0 / Variable.

Punch it in a calculator and see what happens.

As long as Variable !=0 it's ok

[RJay]

You covered (High - Low) but not (Open - Low)

[roonius]

I might be repeating myself, but Open - Low is not a divisor; So is not High - Open;
The only divisor is High - Low

[RJay]

Maybe your right and I just don't get it.

variable * 0 = What?

0 / Variable = What?

I thought this would make any equation explode.

[roonius]

Maybe your right and I just don't get it.

variable * 0 = What?
0 / Variable = What?
I thought this would make any equation explode.

variable * 0 = What? --- 0

0 / Variable = What? --- 0 as long as Variable != 0

You can do 0/Variable but can not Variable/0