Enhanced On Balance Volume Indicator

[T2020]

It'd be nice if what ever was doing it could be resolved , but doesn't appear to be very obvious .... ???

[RJay]

variable * 0 = What? --- 0

0 / Variable = What? --- 0 as long as Variable != 0

You can do 0/Variable but can not Variable/0

Your Right, I apologise. Don't ever get old.

I should have checked before saying anything.

I guess I'm the "zero".

RJay

[T2020]

if (CurrentBar == 0)
{
if((High[0]-Low[0])!=0)
{
volUp.Set(Volume[0]*((High[0]-Open[0])/(High[0]-Low[0])));
volDn.Set(Volume[0]*((Open[0]-Low[0])/(High[0]-Low[0])));
} else
{
volUp.Set(0);
volDn.Set(0);
}
} else

if((High[0]-Low[0])!=0)
{

volUp.Set(volUp[1] + Volume[0]*((High[0]-Open[0])/(High[0]-Low[0])));
volDn.Set(volDn[1] + Volume[0]*((Open[0]-Low[0]) /(High[0]-Low[0])));
}

OBVplot.Set(volUp[0] - volDn[0]);

Is the "if((High[0]-Low[0])!=0)" suppose to take
care of any divide by zero problems ? Maybe it's not doing what it's suppose to . What
if You just went
((High[0]-Open[0])/(High[0]-Low[0] +.00001)));
??

[NinjaTrader_JoshP]

Guys you may be running into double.Epsilon issues. Please review this article: http://www.ninjatrader-support2.com/...ead.php?t=3929

To check for zero do this:

if (High[0] - Low[0] < double.Epsilon)
   // It is zero;

[roonius]

Thank you Ray for reminding me this isue

[roonius]

Thanks again roonius . I notice that there is an extreme spike in the indicator
right at the beginning of a new bar occasionally ,but resumes normal working
almost immediately . Just something I'm leaving feed back on .
I wish i knew how to do this . I'd be adding moving averages to it , trying
certain period summations of the same formula . I could do all that on my
previous software , unfortunately it didn't have anything remotely as good as
the Ninja chart trader ,which I've come to rely on . Oh well . Thanks again .

Let me know if this will solve extreme spikes. I am not experiensing them my self, so I can not test

[T2020]

Let me know if this will solve extreme spikes. I am not experiensing them my self, so I can not test

Will do , thanks again .

[T2020]

Following up

This hasn't seemed to cure the problem here . I did notice the spike is less
extreme on a 30 second chart as opposed to a 1 minute chart . Changing
the 1 min to 60 second actually reduced the severity of the spike . I wonder
if it has something to do with me being on a wireless ISP . Not quite the quality of a land line . Packets get dropped . Using TT not Zen fire ??? It works well enough for me to stick with it . I do think it's better than the regular OBV .

[T2020]

Guys you may be running into double.Epsilon issues. Please review this article: http://www.ninjatrader-support2.com/...ead.php?t=3929

To check for zero do this:

if (High[0] - Low[0] < double.Epsilon)
   // It is zero;

Were you suggesting to add this code to the indicator ? Tried it for the heck
of it . Makes the indicator flat line .

[NinjaTrader_Bertrand]

No, I think this was just an example how the syntax is to be used.

[T2020]

Still spiking away . If it's above zero ,it spikes down to zero and the reverse
if it's below zero . Gets annoying . Mainly watching a 30 second chart .

[NinjaTrader_JoshP]

The code snippet I provided is just for your comparisons. When subtracting doubles, a value greater than epsilon would mean it is not zero. Do a <= check for an equality check of 0.

[T2020]

The code snippet I provided is just for your comparisons. When subtracting doubles, a value greater than epsilon would mean it is not zero. Do a <= check for an equality check of 0.

Any other thoughts why this continues to spike to the zero line ? I added this to the code as a " I'll try anything that might help " .00001 ..... code snip >'

if((High[0]-Low[0])!=0)
{
volUp.Set(volUp[1] + Volume[0]*((High[0]-Open[0])/(High[0]-Low[0]+.00001)));

volDn.Set(volDn[1] + Volume[0]*((Open[0]-Low[0])/(High[0]-Low[0]+.00001)));
}

[NinjaTrader_Bertrand]

T2020, please post a screenshot what you mean by spiking through the zero line...we do not have the bandwidth to debug this, but I would make sure to Plot / Print any calculated value and isolate the one that is being miscalculated...step by step...

[T2020]

This is as close as I can come because the spike only lasts about 1 second .
What I mean is the OBV line will spike down and touch the zero line . I have
drawn a blue line to mark it . Not sure what you mean by not having the bandwidth ?