Simple C# problem

[malcolm]

protected override void OnMarketData(MarketDataEventArgs marketDataUpdate)
{
if (marketDataUpdate.MarketDataType == MarketDataType.Last)
{
if(marketDataUpdate.Price != LastTradePrice)
{
LastTradePrice = marketDataUpdate.Price;
Print("Last = " + LastTradePrice);
}
}
Print("Last high 1 = " + LastHigh);
if (LastTradePrice > LastHigh);
{
LastHigh = LastTradePrice;
Print("Last high = " + LastHigh);
}


}

I am tying to get LastHigh to only change its value when the price goes higher, but it also goes down. I am doing something wrong can you see what?

Thanks

[NinjaTrader_Emily]

Hello Malcolm,

Thank you for your post.

I recommend updating your print statements to include the time as well as all variables involved before and after LastTradePrice and LastHigh are updated. Here is an example of your snippet with some updated print statements:

protected override void OnMarketData(MarketDataEventArgs marketDataUpdate)
{
if (marketDataUpdate.MarketDataType == MarketDataType.Last)
{
if(marketDataUpdate.Price != LastTradePrice)
{
// note: the above could be simplified to if (marketDataUpdate.MarketDataType == MarketDataType.Last && marketDataUpdate.Price != LastTradePrice)
Print(String.Format("{0} MarketDataType: {1} Price: {2} != LastTradeprice: {3}", Time[0], marketDataUpdate.MarketDataType, marketDataUpdate.Price, LastTradePrice));
LastTradePrice = marketDataUpdate.Price;
Print(Time[0] + "LastTradePrice Updated: " + LastTradePrice);
}
}
Print(Time[0] + "Last high 1 = " + LastHigh);
if (LastTradePrice > LastHigh);
{
Print(String.Format("{0} LastTradePrice: {1} > LastHigh: {2}", Time[0], LastTradePrice, LastHigh));
LastHigh = LastTradePrice;
Print(Time[0] + "Last high Updated: " + LastHigh);
}
}

For more information about using prints to debug your script:

https://ninjatrader.com/support/forum/forum/ninjatrader-7/strategy-development-aa/99209-date-conditions-not-working#post791121

Please let me know the results after adding prints with all relevant information. If you are unsure of the results in the output window, you may right-click and Save As to save the output to a file that you may attach to your reply here.

Thank you for your patience.

[Tasker-182]

You are using the != operator which means Not Equal, so if price is not equal to the last saved then it will save the latest different price. I think you want to use the “>;” greater than operator.

Ex: if(marketDataUpdate.Price > LastTradePrice)

[jeronymite]

malcolm You could try something like this:

protected override void OnMarketData(MarketDataEventArgs marketDataUpdate)
{
    if (marketDataUpdate.MarketDataType == MarketDataType.Last)
    {
        double PriorHigh = LastHigh;
        LastHigh = Math.Max(LastHigh,marketDataUpdate.Price);
        if (LastHigh > PriorHigh)
            Print("New High = " + LastHigh);
​    }
}​

This eliminates the use of LastTradePrice, so if you need that, modify accordingly.

Thanks.