Try / catch block in NT8 reference indicator - SpreadOscillator

[Shansen]

NT Forum,

A quick thank you to NinjaTrader_Paul for the NT8 reference indicator: NT8 - Spread Oscillator. I am grateful the indicator has been posted for reference.

The indicator uses a try/catch block for a critical section of the logic in OnBarUpdate(). While this approach works, how could the indicator be re-written without the try/catch block?

It is my understanding exceptions should only be used when an application encounters an exceptional circumstance (MSDN). The basic rule of thumb for catching exceptions is to catch exceptions if and only if you have a meaningful way of handling them (StackOverflow). Using exceptions gratuitously is where you lose performance. For example, you should stay away from things like using exceptions for control flow (StackOverflow).

Could IsValidDataPoint() be used?

As always, any suggestions are welcome

Regards
Shannon

[NinjaTrader_PaulH]

Hello Shansen,

Thanks for your post.

I did not create the indicator but converted it from the NT7 version which included the try/catch blocks.

Doing some historical research the use of the try/catch blocks, in this case, were from initial development of the indicator and are really not needed as the Ninjascript methods are handled by the core and so the try/catch blocks can be removed. I will add this to my todo list to remove the try/catch blocks and then re-upload to the NT8 indicators forum.