Stroke BrushDX null?

[overflowing]

I have a stroke property defined as:

[Description("Some stroke stuff")]
public Stroke SomeStroke { get; set; }

I set a default value:

protected override void OnStateChange()
{
    if (State == State.SetDefaults)
    {
       SomeStroke =  new Stroke(Brushes.Red);

Later on in a method called from OnRender() I make the following call:

RenderTarget.DrawLine(
pointA,
pointB,
stroke.BrushDX,
stroke.Width,
stroke.StrokeStyle);

This causes NinjaTrader to crash. Re-trying and debugging I can see that SomeStroke is a valid object after instantiation BUT SomeStroke.BrushDX is null which I imagine is causing the DrawLine() method to fail.

Is it expected that stroke.BrushDX would be null? Do I have to do something to initialize it?

[overflowing]

I found this thread where it seems gomifromparis encountered the same issue:

Exposing Pens as properties ?


But no one seems to explain why BrushDX is null.

[NinjaTrader_Jesse]

Hello,

Thank you for the question.

As there are a few different types with OnRender now I couldn't determine by your post on what Type this is being used in, could you instead provide a export or .cs version of the script that demonstrates this?

If this can reproduce a crash I could certainly submit that to development for further review.

I look forward to being of further assistance.

[overflowing]

Not sure what you mean by "Type" in this context but it's for an indicator. Here you go, minimal example indicator

[NinjaTrader_Jesse]

Hello,

Thank you for the sample, By type I was simply referring to the type of file I.E. indicator as there are now many types that use OnRender so it may be different depending on the location.

I was able to see this on my end so I have submitted this to development for further review.

I look forward to being of further assistance.

[GaryAlbers]

Any resolution?

Jesse,

I am still having this problem in beta 11. Do you have a fix planned?

What causes the Stroke.BrushDX property to have a valid brush(dx) and once there, will it stay?

Gary

[NinjaTrader_Jesse]

Hello,

Thank you for bringing this up.

I noted that the error still exists, but the documentation surrounding this property has not yet been updated. Mainly the error is now handled internally but what the test was showing was still in error logically. What is happening is the property is being used before it has a RenderTarget set.

To use this property the RenderTarget would need to be set for the stroke before it is used.

The following would be the solution:

MyStroke.RenderTarget = RenderTarget;
RenderTarget.DrawLine(pointA, pointB, MyStroke.BrushDX, MyStroke.Width, MyStroke.StrokeStyle);

To avoid using two lines for a single line statement, you could also use the following:

RenderTarget.DrawLine(pointA, pointB, MyStroke.Brush.ToDxBrush(RenderTarget), MyStroke.Width, MyStroke.StrokeStyle);

I look forward to being of further assistance.