UpdateBar() does not update bar open value

[aslane]

Per discussion in http://www.ninjatrader-support2.com/...ad.php?t=23264, I think there is an issue in the UpdateBar() routine, in that the open value can not be changed. To implement custom bars, this functionality is required.

Because you can not change the open in the bar generation code, you are forced to work around the issue in the bar painting code in the ChartStyle, which works for renko, but then the values that show up in the data window do not match the actual values that the bars show. This is also true if you are trying to use the open values in a strategy/indicator. Effectively, you are forcing work arounds into all kinds of code, instead of just keeping it in the bar generation code where it belongs.

I can understand not wanting to change the routine, due to legacy issues, but there should be a way to change the open of a bar even if it had to be done via a new routine/property (i.e. bar.SetOpen() or bar.Open) to make it explicit since normally you would not need to change the open. Is there a way to do this? If not, please change/add this functionality.

[NinjaTrader_Ray]

I believe this is a limitation that has implications if we changed it which is likely why we have not. I will double check again though.

[aslane]

Yes, I expect there would be some legacy concerns. For that reason, adding a new routine to explicitly set the open would be the way to go. Thanks for looking into.

[NinjaTrader_Dierk]

>> UpdateBar() does not update bar open value
This is by design.

Check out "bars.RemoveLastBar()" in case you needed to replace last bar. Don't try to remove more than one bar by multiples calls in a row. Note: this is beyond what we provide support for.

[aslane]

Perfect. Greatly Appreciated!

[NinjaTrader_Dierk]

Curious: Are you still working on the Renkos? If so, would you mind if we considered incorporated your work in NT? Thanks

[aslane]

Sure, just have someone send me a PM or email, and I will work with you to get you the code and and answer any questions. It entails changes to RenkoBarType and OpenCloseStyle as the two work together.

[NinjaTrader_Dierk]

Excellent, thanks. Appears you have turned off forum messaging. Would you mind firing me a mail to "dierk AT ninjatrader DOT com"? Thanks

[aslane]

FYI, new RenkoBarType code is in NT7B6.

The wick data is there, if you check in the data window. If you want to see wicks, you can enable CandleSticks for renko bars by enabling it in the RenkoBarType class in @BarTypes.cs file like this

public override Gui.Chart.ChartStyleType[] ChartStyleTypesSupported
{
	get { return new Gui.Chart.ChartStyleType[] { Gui.Chart.ChartStyleType.OpenClose, Gui.Chart.ChartStyleType.CandleStick  }; }
}

After making the change, just recompile any indicator and restart NT. You should then be able to select CandleStick in addition to OpenClose chart styles.

[gregid]

Will the next beta allow possibility to change to candlestick type for Renko charts as default (without making any changes to the code)?

Thanks

[NinjaTrader_Dierk]

Thanks for your suggestion. We'll add it to the list of future considerations.

[Eagle]

Hi Aslane
I tried this and it works, however the wicks are only available for the current bar, how would I set it that the wicks remain for the historical bars as well.

thanks

[aslane]

Hi Aslane
I tried this and it works, however the wicks are only available for the current bar, how would I set it that the wicks remain for the historical bars as well.

thanks

Well, this worked perfectly in B6, but Ninja seems to have changed the code quite a bit in B7 so it is completely busted in terms of wicks. That may also be why they did not make the one line of code change to enable CandleSticks that was mentioned in previous post.

I will leave it to the Ninja guys to explain why they made changes and to fix it. Most of the changes look like they were trying to bullet proof the code, but they failed to maintain the wick data when they made the changes. Basically, every AddBar() and UpdateBar() call got messed up because they did not maintain the wick data, and instead used the renko Hi/Lo of the bar.

[Eagle]

Thanks for the reply. Where is your original code supplied to Support. Would it make sense to add this original in the bar types and call it Renko 2 or something? I guess this file gets overwritten with each new version. But could be useful for me for the interim.
thanks

[aslane]

Attached is a zip wile with two files: @BarsTypes.cs and RenkoBarsTypeB6.cs.

The @BarsTypes.cs file is the B7 code with the RenkoBarsType class commented out, and is intended to overwrite original B7 code.

The RenkoBarsTypeB6 file is the version of the code from B6 which works and has candlesticks enabled. (don't have time to repatch the B7 code right now).

You need to extract and drop the two files into the My Docs/NinjaTrader 7/bin/Custom/Type dir (importing this zip file into NT will not work). Before doing, you may want to make a copy of this dir outside of Ninja dir in case something goes wrong. Then go compile any indicator and shut down and restart NT. All should be good.

Hope that works.