Indicator Initialize - Dispose

[maxima]

I dont know what does it mean for a developer. What I see is that if I need to initialise some resource (I have file stream and I have an external window) - once I added one indicator to a chart - I have several of copies being instantiated but only one is used...

If you need some instanses for inner job you had to have 2 separate sets of methods to init and dispose custom classes.. One you use for what you use and one is for the developers... And the use case should be clearly explained.

I hope that will happen in NT7.

[NinjaTrader_Dierk]

Unfortunately nothing will change with NT7 in that regard as all supported features behave well in Initialize().

[maxima]

Yeah I got it.

[zweistein]

Hello,

I use Initialize and Dispose a lot in my code.

In my indicators when I subsitute Dispose with OnTermination my code breaks because OnTermination is never called. Is this a bug or intended?

Dispose is called as usual.
Therefore I will continue to use Dispose.

are there any plans to delete Dispose ?

[NinjaTrader_Dierk]

>> In my indicators when I subsitute Dispose with OnTermination my code breaks because OnTermination is never called
Could you please provide a simple a possible scenario where you feel OnTermination should be called but wasn't. Thanks

[zweistein]

just click F5 (reload ninjascript) should bring you there

[NinjaTrader_Dierk]

I copied the SMA indicator and added this simple method

        protected override void OnTermination()
        {
            Print("OnTermination");
        }

It's triggered every time I hit F5.

[zweistein]

you are correct, OnTermination is called in SMA.

But if you put a function public override void Dispose() in SMA,

then OnTermination is no longer called.


I overlooked this before because the changes will only be visible at the SECOND F5 click (at the first click the old SMA code Dispose/OnTerminate is called, only at the second f5 click the current code base is executed)

regards

[NinjaTrader_Dierk]

Please use OnTermination as advised with NT7 to avoid any further confusion.

[zweistein]

I have code like

Dispose(){
... my stuff

base.Dispose()

}


and base can be a strategy, indicator or marketanalyzer column.
All works perfectly, and in this way I can control my resources properly.


Why don' t you publish the STRUCTURE of your Dispose - OnTermination sequence.

Is it?

IndicatorBase.Dispose(){
OnTermination(); // this calls cleanup in custom indicator

DoNTInternalDispose();
}


Instread

MyIndicator.Dispose(){
DoMyDispose();

base.Dispose();

}

would give exactly the same behaviour.

Only difference is that if a user forgets to call base.Dispose() he could cause exceptions in NT.

Is this the idea behind OnTermination?

[NinjaTrader_Dierk]

We do not provide any support for Dispose() with NT7. Nor should you ever call OnTermination() explicitely. Please clean up your ressources in OnTermination(). Thanks

[zweistein]

"No support..."

Thank you for your reply.
Not supported doesn' t necessarily mean bad code. Sometimes on the contrary, functionality becomes better...

Actually I am only interested to have Dispose() also available in the future. I will use OnTermination where I decide it is the better choice.

From your samples .cs files I see a massive use of Dispose(), so I feel on the safe side...

[NinjaTrader_JoshP]

Reason reference samples use Dispose() is because they are from NT6.5 and OnTermination() did not exist back then.