To make a standard Fib setting as part of script

[trdninstyle]

/* the action branching command will only evaluate as true if actionOccurred is false */
if (actionOccurred == false (Thereby allowing a new action to take place)

/* && your conditions to trigger action here.

This is where my original command branch goes.

for this simple example I'll use the high of the current bar is greater than an SMA,
which will be true for several bars in a row */

if ((actionsOccurred ==false/* && conditions to trigger action*/)
&& (Close[2] > Open[2])
&& (Close[1] > Open[1])
&& (Close[0] > Open[0])
&& (Close[2] > High[3])
&& (Close[1] > High[2])
&& (Close[0] > High[1])
&& (Low[1] > Low[2])
&& (Low[0] > Low[1])
&& BarBrushes[3] != Brushes.Aquamarine)

I guess you had to walk me through it.

[NinjaTrader_ChelseaB]

Hello trdninstyle,

Value[0] = SMA(14)[0]; is just for the example. This sets a plot to the value of an SMA. This is not where the actionOccurred bool is reset to false.
This is also not the action branching command. The action branching command is the one where the logic block triggers the action. In the example script the action is to draw a dot. In your script the action is to set BarBrushes.

[trdninstyle]

Okay, I'm getting there. This is how I initially copied it






4 errors on actionOccurred

[trdninstyle]

The actionOccurred has an error out of context. Could you please show me what I do have right and where it is wrong.

[NinjaTrader_ChelseaB]

Hello trdninstyle,

I see you have a private variable named actionsOccurred declared in the scope of the class.

Where do you have a variable named actionOccurred declared?

[trdninstyle]

I Gotcha lol

I fixed that and turned around the > so it would be greater, if (actionOccurred && barcounter > 3).
It works like a charm now even after I change colors. Thanks

[trdninstyle]

The else if (actionOccurred) the if (actionOccurred && barcounter >3) and else if (State == State.Configure) items are done just once and it applies throughout the script?

Because as I started to do the bear side & I only got to the actionOccurred = true; in the logic block compiled it & I checked the chart and it worked for that too. Or should I place those items in there too? For the bear side in case it causes problems later.

I don't want to put items in there if they are not needed.

Thank you

[NinjaTrader_ChelseaB]

Hello trdninstyle,

An 'else if' clause only applies the 'if' clause it is below.
Meaning you could adjust the code to separate the 'else if' branching command and logic block that increments the barCounter variable.
Or you could add a second bool variable and actionOccured and use those in similar code for another action.

Use prints to understand the behavior of your code. You can print all values in a condition and a value before it is used to see how everything is processing.

[trdninstyle]

I can use the else if for the fib drawings because right now it draws too many, I mean, for the 'weaker' channel then another strong bar it turns into a strong channel and it draws 2 fibs, one for the weaker and one for the stronger and it's too messy. or I should work on the OnRender for those.

But anyway, on the bear side it's working without those else if etc below it, see the pic please. It paints only 3 bars when there are 4 or more, which is good.

It's these two items thats making it work;
(actionOccurred == false/* && conditions to trigger action*/)
actionOccurred = true;

It must be picking up on the else if scenarios from the original. But what your saying is, if I wanted something different here I could put it under here & write it.

[trdninstyle]

Or you could add a second bool variable and actionOccured and use those in similar code for another action.

private bool actionOccurred;
private bool strongerFib;

I added a second bool strongerFib to work with actionOccurred. Would I need to have the else if laid out like the one I just got done with? Or do I just need one else if to go between the weaker fib command branch and the stronger fib command branch. Just for the fib command branch not the actual command branch for coloring of the bars.

Here's how I have it, I know it's not how you would write it up lol, it compiles but its not applicable.

[trdninstyle]

How could I make these fib drawings to draw only the called 3 bars thats being colored? And not from the bars that print afterwards.

[NinjaTrader_ChelseaB]

Hello trdninstyle,

Put the call to Draw.FibonacciRetracements() in the same logic block as the BarBrushes assignments.

[trdninstyle]

I thought about that before & tried it but I did it again and what happens is, if I don't select FibLookBack it won't color in the 3 bars. I have to also put FibLookBack == true in the command branch, unless I make two command branches, one without FibLookBack and the Draw.FibonacciRetracements() in logic block then one with it.

I tried what I just explained above, it doesn't draw the fib but it does keep the 3 bars colored in. Would I have to keep all of the else if's the same for the second command branch & logic block? I placed the 2nd one just under the first one without repeating all of the else if 's.



I'll remove the && BarBrushes[3] != Brushes.Aquamarine) on the 2nd one, then try it.
Makes no difference.

[NinjaTrader_ChelseaB]

Hello trdninstyle,

I'm not advising to make changes to the branching commands or to add this FibLookBack to the branching command.

If you are trying to make the drawing object call optional, then nest a condition within the (outer branch's) logic block.

if ((actionsOccurred ==false/* && conditions to trigger action*/)
{
BarBrushes[0] = MyBrush;

if (FibLookBack == true)
{
Draw.FibonacciRetracements();
}
}

Keep in mind a basic understanding of C# programming is prerequisite to writing NinjaScript code.

https://support.ninjatrader.com/s/article/Developer-Guide-Getting-Started-with-NinjaScript

[trdninstyle]

Like this?